Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: pr7862 #7868

Merged
merged 2 commits into from
Oct 29, 2024
Merged

patch: pr7862 #7868

merged 2 commits into from
Oct 29, 2024

Conversation

andrey-medvedev-vk
Copy link
Contributor

@andrey-medvedev-vk
fix(Gallery): navigation doesn't work when align="center" and slides …
afb1527 
…overflow just a little (#7862)

 Добавлено особое условия в режиме align="center" для подсчёта флага отключения навигации, учитывающее отступ, появляющийся при выравнивании по центру.

В условиях, когда слайды выравниваются по центру, у активного слайда слева появляется отступ от левого края, за счёт которого слайды смещаются вправо.

В такой ситуации перестаёт правильно работать условие, выключающее переключение между слайдами, когда общая ширина слайдов меньше контейнера.

Если общая ширина слайдов меньше контейнера и они за счёт отступа всё же не помещаются в контейнере, то нужно также учесть этот отступ в условии, иначе при отключении навигации будет невозможно полностью увидеть скрытый слайд.
@andrey-medvedev-vk andrey-medvedev-vk added this to the v6.7.4 milestone Oct 29, 2024
@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as ready for review October 29, 2024 11:31
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team as a code owner October 29, 2024 11:31
@andrey-medvedev-vk andrey-medvedev-vk self-assigned this Oct 29, 2024
SevereCloud
SevereCloud previously approved these changes Oct 29, 2024
View reviewed changes
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 29, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 384.78 KB (+0.03% 🔺)
JS (gzip) 116.33 KB (+0.04% 🔺)
JS (brotli) 95.49 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 331.11 KB (0%)
CSS (gzip) 41.34 KB (0%)
CSS (brotli) 32.7 KB (0%)

inomdzhon
inomdzhon previously approved these changes Oct 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

👀 Docs deployed

Commit 883a979

@inomdzhon
Copy link
Contributor

оу, тесты не заробили(

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (fad7e93) to head (883a979).
Report is 1 commits behind head on 6.7-stable.

Additional details and impacted files 
@@             Coverage Diff             @@
##           6.7-stable    #7868   +/-   ##
===========================================
  Coverage       95.17%   95.17%           
===========================================
  Files             383      383           
  Lines           11339    11343    +4     
  Branches         3725     3728    +3     
===========================================
+ Hits            10792    10796    +4     
  Misses            547      547
Flag Coverage Δ
unittests 95.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as draft October 29, 2024 13:19
SevereCloud
SevereCloud approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@SevereCloud SevereCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно поправить тест в ветке v6

@andrey-medvedev-vk
Copy link
Contributor Author

нужно поправить тест в ветке v6

Точно, хорошее замечание, спасибо!

@andrey-medvedev-vk andrey-medvedev-vk marked this pull request as ready for review October 29, 2024 13:42
@andrey-medvedev-vk andrey-medvedev-vk merged commit fe06453 into 6.7-stable Oct 29, 2024
53 checks passed
@andrey-medvedev-vk andrey-medvedev-vk deleted the patch/pr7862 branch October 29, 2024 14:06
@vkcom-publisher
Copy link
Contributor

✅ v6.7.4 🎉

@inomdzhon inomdzhon removed this from the v7.0.0-beta.2 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@andrey-medvedev-vk andrey-medvedev-vk

Labels
None yet
Projects
VKUI
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrey-medvedev-vk @inomdzhon @vkcom-publisher @SevereCloud @EldarMuhamethanov