Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DatePicker): rm component #7840

Merged
merged 3 commits into from
Oct 28, 2024
Merged

feat(DatePicker): rm component #7840

merged 3 commits into from
Oct 28, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Release notes

Описание

Компонент DatePicker был помечен как deprecated и в v7.0.0 нужно его удалить.

Изменения

  • Удалил все связанное с компонентом DatePicker и все его упоминания
  • Добавил кодмод, который только находит в коде DatePicker и показывает варнинг

Release notes

BREAKING CHANGE

@EldarMuhamethanov EldarMuhamethanov added this to the v7.0.0-beta.2 milestone Oct 25, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Oct 25, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 25, 2024 11:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 378.25 KB (-0.72% 🔽)
JS (gzip) 114.6 KB (-0.74% 🔽)
JS (brotli) 94.3 KB (-0.79% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.94 KB (-0.1% 🔽)
CSS (gzip) 42.04 KB (-0.18% 🔽)
CSS (brotli) 33.16 KB (-0.17% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 25, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (e6ce861) to head (df10370).
Report is 18 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7840      +/-   ##
==========================================
+ Coverage   95.14%   95.17%   +0.02%     
==========================================
  Files         377      376       -1     
  Lines       11092    11028      -64     
  Branches     3687     3667      -20     
==========================================
- Hits        10554    10496      -58     
+ Misses        538      532       -6
Flag Coverage Δ
unittests 95.17% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit df10370

@EldarMuhamethanov EldarMuhamethanov merged commit e44a13f into master Oct 28, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/remove-date-picker branch October 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
breaking-change cmp:date-picker
Projects
VKUI
Archived in project
Milestone
v7.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk