-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Card): add mode plain #7824
Conversation
# Conflicts: # packages/vkui/src/components/Card/Card.module.css # packages/vkui/src/components/Card/Card.tsx # packages/vkui/src/components/Card/__image_snapshots__/card-ios-webkit-dark-1-snap.png # packages/vkui/src/components/Card/__image_snapshots__/card-ios-webkit-light-1-snap.png # packages/vkui/src/components/Card/__image_snapshots__/card-vkcom-webkit-dark-1-snap.png # packages/vkui/src/components/Card/__image_snapshots__/card-vkcom-webkit-light-1-snap.png
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 660a5c0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7824 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 376 376
Lines 11043 11044 +1
Branches 3664 3665 +1
=======================================
+ Hits 10531 10532 +1
Misses 512 512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Добавим в стайлгайд? |
Поскольку у карточки нет ни бордеров ни теней, то ее просто видно не будет на обычном фоне. Только разве под нее добавлять какой-то фон особенный, а если добавлять то какой? |
71af39c
@qurle Добавил пример в styleguide |
Там очепятка в инлайновом стиле и шапка другая...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У меня не обновилось по ссылке сверху, но в общем-то доверяю
# Conflicts: # packages/vkui/src/components/Card/Readme.md
Странно, что не обновилось по ссылке, но локально обновилось) |
Описание
Нужно добавить
mode="plain"
для компонентаCard
.Release notes
Улучшения
mode
"plain"