feat(AppRoot): add layout
#5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevereCloud
force-pushed
the
SevereCloud/issue3018
branch
from
8055b8f
to
ee5bed3
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a7b44f:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5642 +/- ##
==========================================
- Coverage 81.93% 81.92% -0.01%
==========================================
Files 296 296
Lines 9780 9800 +20
Branches 3102 3105 +3
==========================================
+ Hits 8013 8029 +16
- Misses 1767 1771 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
👀 Docs deployedCommit ee5bed3 |
e2e tests |
github-actions
bot
added
the
pr-needs-work
inomdzhon
reviewed
Aug 29, 2023
|
В ветке конфликты :( |
Добавляем новое свойство `layout: 'plain' | 'card'` Изменяем вид Group при mode="card" и sizeX="compact" - closed #3018
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
SevereCloud
force-pushed
the
SevereCloud/issue3018
branch
from
ee5bed3
to
3a7b44f
Compare
👀 Docs deployed
Commit 3a7b44f |
github-actions
bot
removed
the
pr-needs-work
eugpoloz
approved these changes
Aug 30, 2023
inomdzhon
added a commit
that referenced
this pull request
Aug 2, 2024
1 task
inomdzhon
added a commit
that referenced
this pull request
Aug 5, 2024
inomdzhon
added a commit
that referenced
this pull request
Aug 7, 2024
h2. Описание - реструктурировал CSS файл, чтобы было понятней что к чему; - размеры заменил на токены из [@vkonktate/vkui-tokens](https://github.com/VKCOM/vkui-tokens/blob/ecdad88decf36df7ad14f5df493ba5adbddae6a5/src/themeDescriptions/base/paradigm.ts#L749-L759); - отказался от использования `<Separator />` из-за того, что его задевает `vkuiInternalModalPage`, вместо этого объединил `Group__separator--spacing` и `Group__separator--separator` в один элемент `Group__separator`; - добавил модификатор `Group--sizeX--regular`, т.к. он определяет `mode` как `"card"` при `sizeX="regular"`, если `mode === "none"`; - вынес `<Separator />` из `<div />` в `ModalPageHeader.tsx`, чтобы боковые отступы не влияли на размеры сепаратора. h3. Дизайн Внутри `ModalPage` При `platform="android"`/`platform="ios"` и `sizeX="regular"` в `ModalPageHeader` удаляем отступы у `Separator`. <img width="320" alt="image" src="https://github.com/user-attachments/assets/104f9be1-d7b5-4d60-8618-1d4dbee904f0"> <img width="313" alt="image" src="https://github.com/user-attachments/assets/53149f5b-e662-4908-9ae1-774b8e475dd8"> _до и после_ --- - related to #5344, #5364, #5371, #5642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавляем новое свойство
layout: 'plain' | 'card'Изменяем вид Group при mode="card" и sizeX="compact"
Groupв соответствии с новыми макетами #3018