Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality feedback #1

Draft
wants to merge 251 commits into
base: feedback-herman
Choose a base branch
from
Draft

Code quality feedback #1

wants to merge 251 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Apr 7, 2023

  1. Dockerfile

    sathi committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    36fa819 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f570c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c98750b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0d9753f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d052cf5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3ac2668 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ca58bbf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    58871e9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    039372b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7fa04bc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3048626 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ae51f1d View commit details
    Browse the repository at this point in the history
  13. space after

    nicomaper committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    d657c9d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    94bccb2 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Configuration menu
    Copy the full SHA
    005cf7a View commit details
    Browse the repository at this point in the history
  2. install bedtools with wget

    nicomaper committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e87d8d8 View commit details
    Browse the repository at this point in the history
  3. using biocontainers

    nicomaper committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    9e70bb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Configuration menu
    Copy the full SHA
    8e7751a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4548b5e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37624d0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    310c176 View commit details
    Browse the repository at this point in the history
  5. multistage build

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8a4275b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8603c99 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d0a3559 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1eb3a15 View commit details
    Browse the repository at this point in the history
  9. user root

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fa99406 View commit details
    Browse the repository at this point in the history
  10. user root apt-get update

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8cb1439 View commit details
    Browse the repository at this point in the history
  11. test wget bedtools

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    769406d View commit details
    Browse the repository at this point in the history
  12. test wget make bedtools

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2944e0a View commit details
    Browse the repository at this point in the history
  13. test wget make gcc bedtools

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    924f922 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    ca3bbab View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    9bfcb19 View commit details
    Browse the repository at this point in the history
  16. install conda

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    66bbbf9 View commit details
    Browse the repository at this point in the history
  17. install conda

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5d2129f View commit details
    Browse the repository at this point in the history
  18. install conda

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d10dfc5 View commit details
    Browse the repository at this point in the history
  19. install conda

    nicomaper committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4828bb2 View commit details
    Browse the repository at this point in the history
  20. new docker image

    sathi committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    cdb35cc View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. adding openpyxl

    nicomaper committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    bffc9bd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. no requirements

    nicomaper committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    708f119 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c07cb5a View commit details
    Browse the repository at this point in the history
  3. first code commit

    nicomaper committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    fc9e07b View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. updated .gitignore

    nicomaper committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9dff4a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93f7a28 View commit details
    Browse the repository at this point in the history
  3. tutorial and config file

    nicomaper committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9ae17fe View commit details
    Browse the repository at this point in the history
  4. Update README.md

    nicomaper authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f32e442 View commit details
    Browse the repository at this point in the history
  5. Update README.md

    nicomaper authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    cd0aff6 View commit details
    Browse the repository at this point in the history
  6. Update README.md

    nicomaper authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    86d2aec View commit details
    Browse the repository at this point in the history
  7. Update README.md

    nicomaper authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    7fdae88 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    8409587 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    332d3f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Update README.md

    nicomaper authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    60ed101 View commit details
    Browse the repository at this point in the history
  2. Update README.md

    nicomaper authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    37dd9d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    51668ef View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    29d2990 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    796b375 View commit details
    Browse the repository at this point in the history
  3. Update README.md

    nicomaper authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    5e8a839 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d046458 View commit details
    Browse the repository at this point in the history
  5. Update README.md

    nicomaper authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    88a786b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fc8d445 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. CREATING LICENSE

    nicomaper authored May 8, 2023
    Configuration menu
    Copy the full SHA
    2df79e9 View commit details
    Browse the repository at this point in the history
  2. Update README.md

    nicomaper authored May 8, 2023
    Configuration menu
    Copy the full SHA
    a0a8fcf View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    87854fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53cbe9c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eedb78d View commit details
    Browse the repository at this point in the history
  4. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    bba407a View commit details
    Browse the repository at this point in the history
  5. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    a1a8a9b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    456ce84 View commit details
    Browse the repository at this point in the history
  7. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    9c25fa9 View commit details
    Browse the repository at this point in the history
  8. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    08d2141 View commit details
    Browse the repository at this point in the history
  9. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    b1bf106 View commit details
    Browse the repository at this point in the history
  10. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    b4ba8cf View commit details
    Browse the repository at this point in the history
  11. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    3f1f29d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8f994ec View commit details
    Browse the repository at this point in the history
  13. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    e98a930 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    be6240b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    22c6af1 View commit details
    Browse the repository at this point in the history
  16. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    0f17c29 View commit details
    Browse the repository at this point in the history
  17. Update README.md

    nicomaper authored May 16, 2023
    Configuration menu
    Copy the full SHA
    abe05f3 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    926dbc3 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Configuration menu
    Copy the full SHA
    d5c2b5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3025f1e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1cbedfe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4e8729a View commit details
    Browse the repository at this point in the history
  5. Update README.md

    nicomaper authored May 17, 2023
    Configuration menu
    Copy the full SHA
    b55a43c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5ab56c6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Update README.md

    nicomaper authored May 23, 2023
    Configuration menu
    Copy the full SHA
    0a41cf8 View commit details
    Browse the repository at this point in the history
  2. Update README.md

    nicomaper authored May 23, 2023
    Configuration menu
    Copy the full SHA
    b257639 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Update README.md

    nicomaper authored May 26, 2023
    Configuration menu
    Copy the full SHA
    3d074b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c4ff1a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c48763 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    12dae82 View commit details
    Browse the repository at this point in the history
  5. Update README.md

    nicomaper authored May 26, 2023
    Configuration menu
    Copy the full SHA
    a633c5a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. maize V5 data files

    nicomaper committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7b93214 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d370d65 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Configuration menu
    Copy the full SHA
    de3407a View commit details
    Browse the repository at this point in the history
  2. remove not ignored file

    nicomaper committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    29634f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    0065d9b View commit details
    Browse the repository at this point in the history
  2. updated .gitignore

    nicomaper committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    475496f View commit details
    Browse the repository at this point in the history
  3. maize v5

    nicomaper committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0c841ee View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. perc of DEGs is TG

    nicomaper committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ff107d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    8ed3442 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9db368b View commit details
    Browse the repository at this point in the history
  3. Create FAQ.md

    nicomaper authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c4ac07e View commit details
    Browse the repository at this point in the history
  4. Update README.md

    nicomaper authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6da04c9 View commit details
    Browse the repository at this point in the history
  5. Update README.md

    nicomaper authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    cac0e7f View commit details
    Browse the repository at this point in the history
  6. Update README.md

    nicomaper authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0cc4423 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d85e700 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. change folders names to zma_v4, update main script accordingly, and u…

    …pdate config file for slurm
    nicomaper committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a1c7716 View commit details
    Browse the repository at this point in the history
  2. comment change SGE to SLURM

    nicomaper committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5ccc55f View commit details
    Browse the repository at this point in the history
  3. Update README.md

    hdbeukel authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0159e74 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Update README.md

    nicomaper authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    dddf327 View commit details
    Browse the repository at this point in the history
  2. Update LICENSE

    nicomaper authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b419abf View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Configuration menu
    Copy the full SHA
    39e4367 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0ad270 View commit details
    Browse the repository at this point in the history
  3. Remove code duplication in main workflow

    Herman DE BEUKELAER committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d127597 View commit details
    Browse the repository at this point in the history
  4. Add missing curly brace

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a059ef2 View commit details
    Browse the repository at this point in the history
  5. Use switch for setting species id

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    2c92d71 View commit details
    Browse the repository at this point in the history
  6. Add missing breaks to switch

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b52ec46 View commit details
    Browse the repository at this point in the history
  7. Exclude nextflow cache dir and logs from version control

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3138b1c View commit details
    Browse the repository at this point in the history
  8. Rename gene metadata files to match other file path structure

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9dfe14d View commit details
    Browse the repository at this point in the history
  9. Rename MotMapsFile_gw and *_lb parameters to just MotifMapsFile

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    ddc800e View commit details
    Browse the repository at this point in the history
  10. Refine gitignore

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f8aa8cf View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6ed11dd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7e39298 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #6 from VIB-PSB/hotfix/motmap-check-if-exists

    Fix bug for checking motif mappings exist
    nicomaper authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e16630a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9231e57 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3b1acb2 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f67e021 View commit details
    Browse the repository at this point in the history
  17. Ignore bin folder

    Herman De Beukelaer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b414990 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Add gitignore

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f8499a3 View commit details
    Browse the repository at this point in the history
  2. Prepare workflows for e2e testing

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    925fb8e View commit details
    Browse the repository at this point in the history
  3. Ignore test outputs

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    02f2ddc View commit details
    Browse the repository at this point in the history
  4. Add first workflow e2e test

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2cac24e View commit details
    Browse the repository at this point in the history
  5. Pass shuffle count as variable to process stats correctly

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4e08207 View commit details
    Browse the repository at this point in the history
  6. Provide shuffle seed for reproducible test results

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d44129b View commit details
    Browse the repository at this point in the history
  7. Add maize test input filtered for chromosome 1

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2798c8f View commit details
    Browse the repository at this point in the history
  8. Update test scenario for maize genome-wide

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f4e604d View commit details
    Browse the repository at this point in the history
  9. Ignore SLURM output and error files

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    dbc6e57 View commit details
    Browse the repository at this point in the history
  10. Fix test file paths

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d5f8f18 View commit details
    Browse the repository at this point in the history
  11. Fix test input folder names

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1aec75a View commit details
    Browse the repository at this point in the history
  12. Reduce maize non-conding genome to chr1 for testing

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3837466 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7d146f5 View commit details
    Browse the repository at this point in the history
  14. Download test motif mapping files only if not already present

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d0e072e View commit details
    Browse the repository at this point in the history
  15. Rename variables to clarify it's maize

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    248778a View commit details
    Browse the repository at this point in the history
  16. Install nf-test only once

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ad716fe View commit details
    Browse the repository at this point in the history
  17. Fix maize test folder names

    Herman De Beukelaer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f34cac4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Output CSV instead of Excel in test runs

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    685236c View commit details
    Browse the repository at this point in the history
  2. Fix csv flag not passed from main workflow

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d5bbab8 View commit details
    Browse the repository at this point in the history
  3. Fix -csv bool flag in python scripts

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4458601 View commit details
    Browse the repository at this point in the history
  4. Remove metavar from csv flag

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    71e6976 View commit details
    Browse the repository at this point in the history
  5. Get rid of non-working boolean flag

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    14a4f6f View commit details
    Browse the repository at this point in the history
  6. Revert "Get rid of non-working boolean flag"

    This reverts commit 14a4f6f.
    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    42e3bea View commit details
    Browse the repository at this point in the history
  7. Use .csv extension for writing csv files

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b1c0f9a View commit details
    Browse the repository at this point in the history
  8. Revert "Revert "Get rid of non-working boolean flag""

    This reverts commit 42e3bea.
    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c81c0ab View commit details
    Browse the repository at this point in the history
  9. Automatically infer export type from file extension

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    07c00d4 View commit details
    Browse the repository at this point in the history
  10. Add arabidopsis test data

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1d140bf View commit details
    Browse the repository at this point in the history
  11. Check csv/excel in special case with empty output too

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    a80caec View commit details
    Browse the repository at this point in the history
  12. Fix integrative results output paths

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1de54fd View commit details
    Browse the repository at this point in the history
  13. Add maize_v4 gw test snapshot

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2511f5d View commit details
    Browse the repository at this point in the history
  14. Add maize_v4 locus-based test case

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1f744cd View commit details
    Browse the repository at this point in the history
  15. Sort TF families in motif centric output for reproducible results

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f23ecb4 View commit details
    Browse the repository at this point in the history
  16. Update test snapshot: maize_v4 genome_wide

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7de457c View commit details
    Browse the repository at this point in the history
  17. Add maize_v4 locus-based test case

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f803566 View commit details
    Browse the repository at this point in the history
  18. Sort output of bps stats

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    41f9729 View commit details
    Browse the repository at this point in the history
  19. Update test snapshot for maize test cases (final)

    Herman De Beukelaer committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8bcabe2 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Add arabidopsis test cases

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    d9ad648 View commit details
    Browse the repository at this point in the history
  2. Fix second gene annotation

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    c6441bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c7ef05b View commit details
    Browse the repository at this point in the history
  4. Add test snapshot

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    1fa1acc View commit details
    Browse the repository at this point in the history
  5. Merge pull request #8 from VIB-PSB/hotfix/second-gene-annot

    Fix second gene annotation - cheked in output network files the median number of TGs per TF, and it increased ~25%, which means that adding the argument "--second_gene_dist 500" had an impact on the final networks.
    nicomaper authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    e9266f3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8848edf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    768eddb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8a7df76 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    372652a View commit details
    Browse the repository at this point in the history
  10. Update test snapshots

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    207915c View commit details
    Browse the repository at this point in the history
  11. Merge branch 'feature/automated-e2e-test' of github.com:VIB-PSB/MINI-…

    …AC into feature/automated-e2e-test
    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    1c60140 View commit details
    Browse the repository at this point in the history
  12. Setup github test workflow

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    2c56453 View commit details
    Browse the repository at this point in the history
  13. Specify singularity version

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    861b3d4 View commit details
    Browse the repository at this point in the history
  14. Fix test config preparation

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    a2a8f2f View commit details
    Browse the repository at this point in the history
  15. Try to resolve tmp folder for singularity

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    11093b1 View commit details
    Browse the repository at this point in the history
  16. Download arabidopsis test motif mapping files from floppy instead of …

    …zenodo (faster)
    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    57ea71e View commit details
    Browse the repository at this point in the history
  17. Attempt to use GitHub runner temp dir

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    705b877 View commit details
    Browse the repository at this point in the history
  18. Rename job

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    85ff1d2 View commit details
    Browse the repository at this point in the history
  19. Atempt again to set tmp dir

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    b65a218 View commit details
    Browse the repository at this point in the history
  20. Explicitly specify bash shell for nf-test

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    5e78ac4 View commit details
    Browse the repository at this point in the history
  21. Try to symlink bash

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    62fa451 View commit details
    Browse the repository at this point in the history
  22. Try running on mac OS

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0eed30c View commit details
    Browse the repository at this point in the history
  23. Explicitly setup java

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    191cb13 View commit details
    Browse the repository at this point in the history
  24. Try again to setup java

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    bd83cec View commit details
    Browse the repository at this point in the history
  25. Enable SSH debugging

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    8b13596 View commit details
    Browse the repository at this point in the history
  26. Debug after failed nf-test run

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    2a54da7 View commit details
    Browse the repository at this point in the history
  27. Try to fix tmp dir

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9e63739 View commit details
    Browse the repository at this point in the history
  28. Try to fix tmp dir

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    eb449a2 View commit details
    Browse the repository at this point in the history
  29. Try to fix tmp dir

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f0c6f47 View commit details
    Browse the repository at this point in the history
  30. Fix default seed (none)

    Herman De Beukelaer committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    3ec2c2c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Merge branch 'feature/automated-e2e-test' into feature/remove-duplica…

    …tion-from-main-workflow
    Herman De Beukelaer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c645c02 View commit details
    Browse the repository at this point in the history
  2. Revert accidental change of p-value for locus-based

    Herman De Beukelaer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b81569c View commit details
    Browse the repository at this point in the history
  3. Provide gene coords for gw mode only

    Herman De Beukelaer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    99ea93b View commit details
    Browse the repository at this point in the history
  4. Correct test input file paths due to rename

    Herman De Beukelaer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b5637ee View commit details
    Browse the repository at this point in the history
  5. Update of documentation for maize genome version NAM5.0 support, and …

    …zma_v4 and zma_v5 folders/files changes
    nicomaper committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    381c4e1 View commit details
    Browse the repository at this point in the history
  6. correction of minor typo

    nicomaper committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    33e52da View commit details
    Browse the repository at this point in the history
  7. Pass full params object from main workflow to gw and lb workflows

    Herman De Beukelaer committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d70ee8d View commit details
    Browse the repository at this point in the history
  8. Make the usage command more general, specify what species/mode the ex…

    …ample should be, and separating the wget commands based on species/genome version
    nicomaper committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    81d718e View commit details
    Browse the repository at this point in the history
  9. Merge pull request #10 from VIB-PSB/hotfix/documentation-update

    Updating documentation to maize genome version 5 addition
    nicomaper authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6fa68d5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b63867c View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Merge pull request #12 from VIB-PSB/hotfix/documentation-update

    Correct typo of wget download command missing -O flag
    hdbeukel authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    961da93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e9d0f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6baf449 View commit details
    Browse the repository at this point in the history
  4. update on .gitignore

    nicomaper committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    bef0d07 View commit details
    Browse the repository at this point in the history
  5. update on .gitignore

    nicomaper committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    849a9c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Add newline at end of gitignore

    Herman DE BEUKELAER committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fe52fa2 View commit details
    Browse the repository at this point in the history
  2. Remove script to run tests on SLURM and refactor GitHub action

    Herman DE BEUKELAER committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    10737be View commit details
    Browse the repository at this point in the history
  3. Fix path when fetching zma_v4 chr1 motif mapping test files

    Herman DE BEUKELAER committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8e0bb3e View commit details
    Browse the repository at this point in the history
  4. update citation

    nicomaper committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b8e4934 View commit details
    Browse the repository at this point in the history
  5. update citation

    nicomaper committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5c27486 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #14 from VIB-PSB/hotfix/update-tpj-citation

    Update of TPJ citation without volume, issue and page range.
    nicomaper authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3cb9481 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'main' into dev

    Herman DE BEUKELAER committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ff9d67b View commit details
    Browse the repository at this point in the history
  8. Merge branch 'dev' into feature/automated-e2e-test

    Herman DE BEUKELAER committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    cab3d78 View commit details
    Browse the repository at this point in the history
  9. Attempt to remove empty workflow block from tests

    Herman DE BEUKELAER committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b799748 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #9 from VIB-PSB/feature/automated-e2e-test

    Automated e2e test
    nicomaper authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    db632dc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge pull request #15 from VIB-PSB/dev

    Release 1.1 - e2e test
    nicomaper authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    24eef94 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    9200afb View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge pull request #3 from VIB-PSB/feature/remove-duplication-from-ma…

    …in-workflow
    
    Remove code duplication in main workflow
    nicomaper authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    ed3f43d View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'dev'

    Nicolas MANOSALVA PEREZ committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2529b67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6503a60 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from VIB-PSB/feature/remove-commented-code

    Remove commented code
    hdbeukel authored May 13, 2024
    Configuration menu
    Copy the full SHA
    d637a1f View commit details
    Browse the repository at this point in the history
  4. Merge pull request #20 from VIB-PSB/main

    Main -> dev
    nicomaper authored May 13, 2024
    Configuration menu
    Copy the full SHA
    7d191b4 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #19 from VIB-PSB/dev

    Dev
    hdbeukel authored May 13, 2024
    Configuration menu
    Copy the full SHA
    da1b4dd View commit details
    Browse the repository at this point in the history
  6. Merge branch 'main' of https://github.com/VIB-PSB/MINI-AC

    Nicolas MANOSALVA PEREZ committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4615ed9 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #21 from VIB-PSB/dev

    Dev
    nicomaper authored May 13, 2024
    Configuration menu
    Copy the full SHA
    5193b83 View commit details
    Browse the repository at this point in the history
  8. update gitignore on slurm output files

    Nicolas MANOSALVA PEREZ committed May 13, 2024
    Configuration menu
    Copy the full SHA
    977a855 View commit details
    Browse the repository at this point in the history
  9. input ACR directory is given as a channel to the gw and lb workflows

    Nicolas MANOSALVA PEREZ committed May 13, 2024
    Configuration menu
    Copy the full SHA
    12c8781 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. scripts for run of MINI-AC using iCREs - first commit

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5020e69 View commit details
    Browse the repository at this point in the history
  2. Gene sets to run the example test

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    216bfdf View commit details
    Browse the repository at this point in the history
  3. updated gitignore to not upload icres bed fies (too big) and icres ou…

    …tput files (confidential)
    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    78b7442 View commit details
    Browse the repository at this point in the history
  4. MINI-AC iCREs config file

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8075032 View commit details
    Browse the repository at this point in the history
  5. Making the commented annotations more homogeneous

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5e0c1d4 View commit details
    Browse the repository at this point in the history
  6. Documentation update for iCREs-based MINI-AC

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5310f43 View commit details
    Browse the repository at this point in the history
  7. Ignoring the files within "outputs_icres" but not the folder itself

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    405b3f1 View commit details
    Browse the repository at this point in the history
  8. Keep empty folders with icres and icres outputs

    Nicolas MANOSALVA PEREZ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c0802f0 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. iCREs documentation update

    Nicolas MANOSALVA PEREZ committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cee26ab View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Documentation update

    Nicolas MANOSALVA PEREZ committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5ec1497 View commit details
    Browse the repository at this point in the history
  2. Correction of code annotation

    Nicolas MANOSALVA PEREZ committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2e11b31 View commit details
    Browse the repository at this point in the history
  3. Update on arguments parsing options

    Nicolas MANOSALVA PEREZ committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6d49e9e View commit details
    Browse the repository at this point in the history
  4. Code annotation type

    Nicolas MANOSALVA PEREZ committed May 23, 2024
    Configuration menu
    Copy the full SHA
    463ec11 View commit details
    Browse the repository at this point in the history
  5. Removal of nargs parameter in arguments parsing

    Nicolas MANOSALVA PEREZ committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4620bbc View commit details
    Browse the repository at this point in the history
  6. Merge pull request #22 from VIB-PSB/feature/icres-based-grns

    Feature/icres based grns
    nicomaper authored May 23, 2024
    Configuration menu
    Copy the full SHA
    3736ff6 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge pull request #23 from VIB-PSB/dev

    iCREs-based GRN inference feature
    nicomaper authored May 24, 2024
    Configuration menu
    Copy the full SHA
    04f1a87 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Making the iCREs files public with download instructions

    Nicolas MANOSALVA PEREZ committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e2931f8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #24 from VIB-PSB/feature/icres-based-grns

    Making the iCREs files public with download instructions
    nicomaper authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a564d54 View commit details
    Browse the repository at this point in the history