Single thread #18
Merged
Single thread #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the new version will be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the harmonization and aggregation of the clipped datasets in favor of a new tool to aggregate multiple datasets. It also removes all uses of async, parallel file writing using multiple threads. This makes the tool slower, especially when working with NetCDF, but it runs MUCH more stable now and is way easier to debug.
This should remove most of the issues we had.
Please be aware that a lot of the old stuff is still in the repo, until I migrated this to the new aggregation tool.
@elnazazmi @safabouguezzi @KB1994: please note, as soon as this is released as version 0.10.0, the parameters to the tool have changed:
1 parameter was added:
cell_touches, which has a default ofTrueand currently there is no need to expose that to the user.The following parameters have been removed:
integration,keep_data_files,precision,resolutionandapply_aggregationas these were all related to the aggregation.This is for your notice, as it might require changes to the UI. I will update the Readme after the merge and then release the new version (which will also trigger the new building of the new image)