-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make_hillslope_geometry #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ashish,
very nice that you are working on the catflow preprocessing tool and cleaned up all the mess I left years ago. I just saw your PR and thought I'd add a quick review. I did not download the tool to test it locally, so I cannot say if the tool works for me, I was just going through the code and added some comments.
Two further more general comments:
- You could think about moving the
_old
functions into a folderdepracated
, I think this tidier. - You also included the results for you exemplary hillslope to the
out/
folder on Github. I am not sure this is wanted, but it certainly gives a nice overview of the potential outputs of the tool. But a user would need to clear theout/
folder before he runs his tool locally.
So nice work, if you want, I can also test the tool locally.
Hey Alex! |
Hi
This PR will update the CATFLOW tool to comply with the latest tool specifications. Currently, the only function implemented is
make_hillslope_geometry
, which generates a required.geo
file from.tif
files.Older files, marked with "_old" in their names, will be deleted as development continues.
AMJ