Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_hillslope_geometry #4

Merged
merged 14 commits into from
Nov 5, 2024
Merged

make_hillslope_geometry #4

merged 14 commits into from
Nov 5, 2024

Conversation

Ash-Manoj
Copy link
Collaborator

Hi
This PR will update the CATFLOW tool to comply with the latest tool specifications. Currently, the only function implemented is make_hillslope_geometry, which generates a required .geo file from .tif files.
Older files, marked with "_old" in their names, will be deleted as development continues.
AMJ

@Ash-Manoj Ash-Manoj requested a review from mmaelicke November 4, 2024 13:41
Copy link
Collaborator

@AlexDo1 AlexDo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ashish,
very nice that you are working on the catflow preprocessing tool and cleaned up all the mess I left years ago. I just saw your PR and thought I'd add a quick review. I did not download the tool to test it locally, so I cannot say if the tool works for me, I was just going through the code and added some comments.

Two further more general comments:

  • You could think about moving the _old functions into a folder depracated, I think this tidier.
  • You also included the results for you exemplary hillslope to the out/ folder on Github. I am not sure this is wanted, but it certainly gives a nice overview of the potential outputs of the tool. But a user would need to clear the out/ folder before he runs his tool locally.

So nice work, if you want, I can also test the tool locally.

Dockerfile Show resolved Hide resolved
src/docker_commands.txt Outdated Show resolved Hide resolved
src/hillslope_method.R Show resolved Hide resolved
src/hillslope_method.R Outdated Show resolved Hide resolved
src/hillslope_method.R Outdated Show resolved Hide resolved
src/hillslope_method.R Show resolved Hide resolved
src/tool.yml Show resolved Hide resolved
@Ash-Manoj
Copy link
Collaborator Author

Hey Alex!
Thanks so much for taking the time to review this again. I will check the comments and add a new commit before merging.
It would be fantastic if you could also download and test the tool locally.
Thanks again!
AMJ

@Ash-Manoj Ash-Manoj merged commit 0dda3b6 into main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants