Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pca #102

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Pca #102

wants to merge 21 commits into from

Conversation

necrolyte2
Copy link
Member

I'm not even sure what this branch was about, but putting up so we can review and what not

Panciera and others added 21 commits July 22, 2015 17:52
…s. Can supply substitution matrix on command line. Fixed bug with unindexed dataframe which was very slow
… as I was not getting them. By default they go to the commit author
@averagehat
Copy link
Contributor

The alternative lives here: #43
docs: https://github.com/averagehat/bio_pieces/blob/881256455a581886027781557b0e0601eb93d631/docs/scripts/make_pcoa.rst

I never re-opened that PR against master.

@necrolyte2
Copy link
Member Author

It seems that the other PR is better as it utilizes emperor which if I remember correctly was just better overall?

@averagehat
Copy link
Contributor

that's what we decided at the time. I'll re-open that PR. I wouldn't want to lose this code altogether, though, as it might be useful later, even if just as a reference. Maybe just not delete the branch?

@necrolyte2
Copy link
Member Author

I don't like 'dirty' branches haha, but ya. I would just leave this PR open then with these comments otherwise might forget later why that branch exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants