Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Anycable #10

Merged
merged 5 commits into from
May 13, 2024
Merged

feat: Anycable #10

merged 5 commits into from
May 13, 2024

Conversation

aablinov
Copy link
Collaborator

@aablinov aablinov commented May 9, 2024 •
edited
Loading

➕ AnyCable SSE server
➕ Fixed selenium-web-driver

@aablinov aablinov self-assigned this May 9, 2024
@aablinov aablinov requested a review from goodsign May 9, 2024 14:19
@aablinov aablinov marked this pull request as ready for review May 9, 2024 14:19
goodsign
goodsign approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@goodsign goodsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Great job
⚠️ I'd suggest to add AnyCable to main repository Readme. Right now it explicitly says:

Real-time page updates for your Rails app over SSE with Mercure or Fanout Cloud

Plus in the bottom configuration documentation it's not mentioned too.

.github/workflows/main.yml Show resolved Hide resolved
@aablinov aablinov merged commit d8da603 into main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsign goodsign goodsign approved these changes

Assignees

@aablinov aablinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aablinov @goodsign