Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #136 - Allow to use Ionic CLI #141

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for issue #136 - Allow to use Ionic CLI #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5d7a05
Fix for #136
jayserdny Oct 22, 2017
533d793
Fix for #136 allow to use ionic cli to run this application
jayserdny Oct 22, 2017
3dbee25
Webpack lint fix
jayserdny Oct 22, 2017
ba30de3
Commands fixed to support the flags and renamed them by platform
jayserdny Oct 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/server/.meteorignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
**/*.js
**/*.js.map
Copy link
Author

@jayserdny jayserdny Oct 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude all .js & .js.map files to avoid conflicts with typescript compiler

6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
"lint": "ionic-app-scripts lint",
"ionic:build": "ionic-app-scripts build",
"ionic:serve": "ionic-app-scripts serve",
"meteor-client:bundle": "meteor-client bundle -s api -c meteor-client.config.json"
"meteor-client:bundle": "meteor-client bundle -s api -c meteor-client.config.json",
"tsc-compiler": "tsc",
"cordova-run": "ionic cordova run",
"android": "cd api/server && npm run tsc-compiler && cd ../.. && npm run cordova-run android -- ",
"ios": "cd api/server && npm run tsc-compiler && cd ../.. && npm run cordova-run ios -- "
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts added

  • "tsc-compiler" - to run the Typescript compiler in the given folder
  • "cordova-run" - to tell ionic to run the app using cordova
  • "android" - to run the application with the platform android
  • "ios" - to run the application with the platform ios

},
"dependencies": {
"@agm/core": "^1.0.0-beta.1",
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,4 +182,4 @@ function resolveMeteor(request, callback) {
module.exports = {
dev: devConfig,
prod: prodConfig
}
};