Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications for Greater London #61

Merged
merged 21 commits into from
Nov 1, 2024

Conversation

sgreenbury
Copy link
Collaborator

Closes #58.

This PR includes modifications to enable the pipeline to run for Greater London (preparation and matching scripts, with the assignment scripts remaining to be tested).

@Hussein-Mahfouz
Copy link
Collaborator

Hussein-Mahfouz commented Oct 23, 2024

We're going to have to set travel_times = false in the config for anywhere that's not Leeds for now. This can change in the future if we decide to implement #20

@sgreenbury sgreenbury marked this pull request as ready for review October 24, 2024 09:38
Copy link
Collaborator

@Hussein-Mahfouz Hussein-Mahfouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've just left two minor comments, otherwise happy to merge

config/base_all.toml Outdated Show resolved Hide resolved
src/acbm/config.py Outdated Show resolved Hide resolved
src/acbm/matching.py Show resolved Hide resolved
@sgreenbury
Copy link
Collaborator Author

Thanks for reviewing @Hussein-Mahfouz, merging now.

@sgreenbury sgreenbury merged commit 82850ee into iterative_categorical_matching Nov 1, 2024
4 checks passed
@sgreenbury sgreenbury deleted the 58-greater-london branch November 1, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants