Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osmox #40

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

osmox #40

wants to merge 8 commits into from

Conversation

Hussein-Mahfouz
Copy link
Collaborator

Related to #19 and #39. We can either:

  • implement logic in this comment
  • point the user to osmox and tell them where to place the output file once they've created it

@sgreenbury
Copy link
Collaborator

sgreenbury commented Oct 18, 2024

Remaining tasks:

  • Update the output format to geoparquet
  • Update the output path to interim/osmox and change the downstream scripts to point to this
  • Check minimum python version issue with 3.12
  • Ensure the output from pyrosm matches the region config name

@sgreenbury
Copy link
Collaborator

Adding the deps mentioned for osmium fixes the CI for Python 3.12 (b54cff0)

@Hussein-Mahfouz
Copy link
Collaborator Author

Do these dependencies need to be added to the poetry lock file?

@sgreenbury
Copy link
Collaborator

Do these dependencies need to be added to the poetry lock file?

Since they're external system deps to python I don't think we're able to install with poetry though we can add this to a requirements section in the docs and link to the osmium docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants