-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upipe-modules: add upipe_pad #749
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is sad that you do a memcpy of the picture which seems unnecessary. Why don't you just set hmprepend, hmappend, vprepend and vappend during a flow format negotiation?
include/upipe-modules/upipe_pad.h
Outdated
* Authors: James Darnley | ||
* | ||
* This library is free software; you can redistribute it and/or | ||
* modify it under the terms of the GNU Lesser General Public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In upipe-modules you can only have MIT-licensed code. If you need LGPL, put it in upipe-filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to MIT
include/upipe-modules/upipe_pad.h
Outdated
* @short Upipe module to pad picture urefs with blank space. | ||
*/ | ||
|
||
#ifndef _UPIPE_FILTERS_UPIPE_PAD_H_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it coherent with the directory name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
lib/upipe-modules/upipe_pad.c
Outdated
} | ||
} | ||
|
||
/** @internal @This is the static zoneplate source pipe manager. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not zoneplate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
tests/upipe_pad_test.c
Outdated
* Copyright (C) 2014-2016 OpenHeadend S.A.R.L. | ||
* | ||
* Authors: Sebastien Gougelet | ||
* Christophe Massiot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about the names ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
Oh. Looks like I copy-pasted too much. Sorry and thank you for catching all that. I need to copy because there seems to be no opportunity to modify the ubuf_mgr request that comes out of upipe_avcodec_decode (avcdec) when it is deported to a worker thread. avcdec calls its demand_ubuf_mgr function from UPIPE_HELPER_UBUF_MGR so it falls back to getting one from the probe when the request isn't answered in the normal manner. I assume it doesn't pass the thread boundary so it can't pass to the usual pipe we use, upipe_ntsc_prepend. This is only something we recently discovered. Usually we have upipe_ffmt and upipe_sws between the two to convert to 4:2:2 but with that as input they don't need to do anything so they don't send their own asynchronous request for a ubuf_mgr which upipe_ntsc_prepend normally modifies. |
A module to pad picture urefs with blank space.
No description provided.