upipe-modules: add upipe_pad #749
Conversation
include/upipe-modules/upipe_pad.h
Outdated
| * Authors: James Darnley | ||
| * | ||
| * This library is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public |
There was a problem hiding this comment.
In upipe-modules you can only have MIT-licensed code. If you need LGPL, put it in upipe-filters.
include/upipe-modules/upipe_pad.h
Outdated
| * @short Upipe module to pad picture urefs with blank space. | ||
| */ | ||
|
|
||
| #ifndef _UPIPE_FILTERS_UPIPE_PAD_H_ |
There was a problem hiding this comment.
Make it coherent with the directory name.
lib/upipe-modules/upipe_pad.c
Outdated
| } | ||
| } | ||
|
|
||
| /** @internal @This is the static zoneplate source pipe manager. */ |
tests/upipe_pad_test.c
Outdated
| * Copyright (C) 2014-2016 OpenHeadend S.A.R.L. | ||
| * | ||
| * Authors: Sebastien Gougelet | ||
| * Christophe Massiot |
There was a problem hiding this comment.
Are you sure about the names ?
|
Oh. Looks like I copy-pasted too much. Sorry and thank you for catching all that. I need to copy because there seems to be no opportunity to modify the ubuf_mgr request that comes out of upipe_avcodec_decode (avcdec) when it is deported to a worker thread. avcdec calls its demand_ubuf_mgr function from UPIPE_HELPER_UBUF_MGR so it falls back to getting one from the probe when the request isn't answered in the normal manner. I assume it doesn't pass the thread boundary so it can't pass to the usual pipe we use, upipe_ntsc_prepend. This is only something we recently discovered. Usually we have upipe_ffmt and upipe_sws between the two to convert to 4:2:2 but with that as input they don't need to do anything so they don't send their own asynchronous request for a ubuf_mgr which upipe_ntsc_prepend normally modifies. |
A module to pad picture urefs with blank space.
No description provided.