udp_source/sink: Check for existing fd and close it during set_fd

Upipe · Aug 26, 2024 · 509edbf · 509edbf
1 parent 4ab2f4c
commit 509edbf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/upipe-modules/upipe_udp_sink.c b/lib/upipe-modules/upipe_udp_sink.c
@@ -516,6 +516,8 @@ static int _upipe_udpsink_control(struct upipe *upipe,
         case UPIPE_UDPSINK_SET_FD: {
             UBASE_SIGNATURE_CHECK(args, UPIPE_UDPSINK_SIGNATURE)
             upipe_udpsink_set_upump(upipe, NULL);
+            if (likely(upipe_udpsink->fd != -1))
+                close(upipe_udpsink->fd);
             upipe_udpsink->fd = va_arg(args, int );
             return UBASE_ERR_NONE;
         }

diff --git a/lib/upipe-modules/upipe_udp_source.c b/lib/upipe-modules/upipe_udp_source.c
@@ -407,6 +407,8 @@ static int _upipe_udpsrc_control(struct upipe *upipe,
         case UPIPE_UDPSRC_SET_FD: {
             UBASE_SIGNATURE_CHECK(args, UPIPE_UDPSRC_SIGNATURE)
             upipe_udpsrc_set_upump(upipe, NULL);
+            if (likely(upipe_udpsrc->fd != -1))
+                close(upipe_udpsrc->fd);
             upipe_udpsrc->fd = va_arg(args, int );
             return UBASE_ERR_NONE;
         }