First draft of creating images chapter #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
fherreazcue
requested changes
Oct 14, 2024
code/Dockerfile
Outdated
There was a problem hiding this comment.
why not put this in another directory? as in SPUCv2 or something?
There was a problem hiding this comment.
Yep fair enough I was in two minds about putting it in anyway as it is more learner output than reference material - guess it doesn't hurt to include it somewhere!
| @@ -34,7 +34,7 @@ | |||
|
|
|||
| # ------------------------------------------------------------------------------ | |||
| # Endpoint for exporting the unicorn sightings if the EXPORT environment variable is set to True | |||
| if os.environ.get("EXPORT").lower() == "true": | |||
| if os.environ.get("EXPORT") == "True": | |||
There was a problem hiding this comment.
Is this more restricting intentionally, or was it not working?
There was a problem hiding this comment.
Not working :'(
|
Still need to review text, but merging to make our lives easier... |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Auto-generated via `{sandpaper}`
Source : 27dae23
Branch : main
Author : Francisco Herrerías-Azcué <[email protected]>
Time : 2024-10-15 19:28:44 +0000
Message : Merge pull request #35 from UoMResearchIT/dockerfiles
First draft of creating images chapter
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Auto-generated via `{sandpaper}`
Source : 3f1d48e
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-15 19:29:43 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 27dae23
Branch : main
Author : Francisco Herrerías-Azcué <[email protected]>
Time : 2024-10-15 19:28:44 +0000
Message : Merge pull request #35 from UoMResearchIT/dockerfiles
First draft of creating images chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.