Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/drop use of ndjson dep, use local code #3886

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

rbiseck3
Copy link
Contributor

Description

Avoid using the ndjson dependency due to the limiting license that exists on it

@rbiseck3 rbiseck3 requested review from scanny and cragwolfe January 23, 2025 18:22
@rbiseck3 rbiseck3 force-pushed the roman/drop-ndjson-lib branch from 7342e12 to f250efc Compare January 23, 2025 18:23
Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple remarks, otherwise looks fine to me.

unstructured/file_utils/ndjson.py Show resolved Hide resolved
unstructured/file_utils/ndjson.py Outdated Show resolved Hide resolved
unstructured/file_utils/ndjson.py Outdated Show resolved Hide resolved
@rbiseck3 rbiseck3 requested a review from scanny January 23, 2025 19:54
Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rbiseck3 rbiseck3 added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit e230364 Jan 24, 2025
41 checks passed
@rbiseck3 rbiseck3 deleted the roman/drop-ndjson-lib branch January 24, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants