Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui stuff #187

Open
wants to merge 3 commits into
base: daddy
Choose a base branch
from
Open

Gui stuff #187

wants to merge 3 commits into from

Conversation

MamiyaOtaru
Copy link
Contributor

# starting to add some windows specific stuff

Enables FileOpenDialog etc. that's already in WindowsSpecificFunctions, and adds MouseGetPos, MouseClick, etc. Only absolute positions so far, relative not yet handled. Would love to see some of the GUI automation stuff in here, this is just a start, to learn what's going on. If you take this and run with it, cool! Otherwise I may add some more as I run into use cases


click stuff, beginning of
added some clicking stuff back after merge from upstream daddy
@Unknown6656 Unknown6656 self-requested a review March 26, 2024 17:21
@Unknown6656 Unknown6656 self-assigned this Mar 26, 2024
Copy link
Owner

@Unknown6656 Unknown6656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that your branch is currently work-in-progress, but I wanted to warn you, that targeting net8.0-windows will NOT be possible, as this project needs to run under Linux and MacOS as well.

@@ -1,9 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net8.0-windows</TargetFramework>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unfortunately cannot permit binding to netX.X-windows, as the project would not be runnable on MacOS or Linux (which is the ultimate aim of this project).
Please change it back to net8,0. If you need windows-specific functions, use direct P/Invoke calls to the Windows Libraries (and if possible, provide also POSIX-compatible alternative code for non-Windows operating systems).

<EnablePreviewFeatures>true</EnablePreviewFeatures>
<LangVersion>preview</LangVersion>
<UseWindowsForms>true</UseWindowsForms>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same rule applies as to the comment above.

@@ -6,6 +6,7 @@
using System.Linq;
using System.Text;
using System;
using System.Drawing;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik not possible under Linux and MacOS, correct me if I'm wrong.


using Unknown6656.Mathematics;
using Unknown6656.Generics;

using Unknown6656.AutoIt3.Extensibility;
using Unknown6656.AutoIt3.Runtime.Native;
using Unknown6656.AutoIt3.Runtime;
using System.Drawing;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same potential issue as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants