fix file bundle name bug #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we change the Addressable Group's file bundle naming mode to file name, the ODR bundles will not be generated correctly as the file names/paths are not modified with the removal of their respective hashes in both the settings_odr.json file and the primary keys of their respective locations. This, in turn, results in incorrect file paths when trying to load these ODR bundles.
Fix: Added two condition checks that check if the bundle naming mode is file name and if so, we simply remove the hashes from the file names before writing them to the settings file and the primary keys.