Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jacodb-api] For loading any SPI, do not use context classloader #267

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Saloed
Copy link
Collaborator

@Saloed Saloed commented Sep 16, 2024

No description provided.

Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 55s ⏱️ ±0s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 5727db1. ± Comparison against base commit 3377c0c.

Copy link
Contributor

Test results on JDK 19

   85 files  ±0     85 suites  ±0   14m 7s ⏱️ +16s
2 515 tests ±0  2 474 ✅ ±0  41 💤 ±0  0 ❌ ±0 
2 543 runs  ±0  2 502 ✅ ±0  41 💤 ±0  0 ❌ ±0 

Results for commit 5727db1. ± Comparison against base commit 3377c0c.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.81%. Comparing base (3377c0c) to head (5727db1).
Report is 1 commits behind head on neo.

Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #267      +/-   ##
============================================
- Coverage     58.81%   58.81%   -0.01%     
  Complexity     2298     2298              
============================================
  Files           315      315              
  Lines         18631    18631              
  Branches       2996     2996              
============================================
- Hits          10958    10957       -1     
  Misses         6577     6577              
- Partials       1096     1097       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Test results on JDK 11

   85 files  ±0     85 suites  ±0   17m 46s ⏱️ + 1m 52s
2 515 tests ±0  2 476 ✅ ±0  39 💤 ±0  0 ❌ ±0 
2 543 runs  ±0  2 504 ✅ ±0  39 💤 ±0  0 ❌ ±0 

Results for commit 5727db1. ± Comparison against base commit 3377c0c.

Copy link
Contributor

Test results on JDK 8

   85 files  ±0     85 suites  ±0   22m 7s ⏱️ -20s
2 515 tests ±0  2 471 ✅ ±0  44 💤 ±0  0 ❌ ±0 
2 543 runs  ±0  2 499 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 5727db1. ± Comparison against base commit 3377c0c.

@Saloed Saloed merged commit c37de8f into neo Sep 16, 2024
11 checks passed
@Saloed Saloed deleted the saloed/fix-spi-loader branch September 16, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant