Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scoreline bonus only allowing values up to 990 instead of 1000 #910

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

barbeque-squared
Copy link
Member

An alternate fix for #844

This probably obsoletes #903 but I'll give @DeinAlptraum a chance to test it first

Some random Pascal that probably describes better what this PR does:

writeln ('OLD BEHAVIOUR');
writeln(Floor(989.499 / 10) * 10); // 980
writeln(Floor(989.500 / 10) * 10); // 980
writeln(Floor(999.499 / 10) * 10); // 990
writeln(Floor(999.500 / 10) * 10); // 990
writeln(Floor(999.999 / 10) * 10); // 990

writeln('NEW BEHAVIOUR');
writeln(Floor(Round(989.499) / 10) * 10); // 980
writeln(Floor(Round(989.500) / 10) * 10); // 990
writeln(Floor(Round(999.499) / 10) * 10); // 990
writeln(Floor(Round(999.500) / 10) * 10); // 1000
writeln(Floor(Round(999.999) / 10) * 10); // 1000

If it's supposed to go to a 1000 at 995 already, we can change that again in a future PR if needed. This PR focuses on making 1000 actually possible.

@barbeque-squared barbeque-squared linked an issue Oct 7, 2024 that may be closed by this pull request
@DeinAlptraum
Copy link
Contributor

Looks good to me and works well 👍🏼

@basisbit basisbit merged commit e6bb354 into master Oct 8, 2024
5 checks passed
@basisbit basisbit deleted the fix-scoreline-bonus branch October 8, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The highest possible score is 9990
3 participants