Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less untracked files on Windows #905

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

barbeque-squared
Copy link
Member

Since #889, running dldlls.py creates a bunch of untracked files on Windows. these hinder development, so gitignore the resulting files.

@DeinAlptraum
Copy link
Contributor

DeinAlptraum commented Oct 6, 2024

This also ignores files such as game/bass.dll which are currently checked into the repo, is that intended?

@barbeque-squared
Copy link
Member Author

If they're already checked-in they should still be tracked (as in: show up as deleted if you delete them, show up as modified if you change them) but I'll verify this theory before merging it. It just means that if we ever add a new DLL to the usdx repo (and not mxe) you'd have to manually git add the thing and maybe --force because of the gitignore (I'll also verify this bit)

@barbeque-squared
Copy link
Member Author

Already-tracked files are still tracked as normal.

If you need to add a new DLL:

[USDX]$ >game/lmao.dll
[USDX]$ git status game/*.dll
On branch windows-ignores
Your branch is up to date with 'origin/windows-ignores'.

nothing to commit, working tree clean
[USDX]$ git add game/lmao.dll
The following paths are ignored by one of your .gitignore files:
game/lmao.dll
hint: Use -f if you really want to add them.
hint: Disable this message with "git config advice.addIgnoredFile false"

which I think is fair for the what, once a year we maybe do something with this versus not having idk how many lines of "untracked file" spam for every Windows developer out there

@barbeque-squared barbeque-squared merged commit f145dc0 into master Oct 7, 2024
5 checks passed
@barbeque-squared barbeque-squared deleted the windows-ignores branch October 7, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants