Fix downloading of DLL releases #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge requests from other repositories will not have access to the secret used for the ARTIFACT_ACCESS_TOKEN environment variable. The variable will be set to an empty string. Using an empty token in the Authorization header makes Github reject requests which would be allowed without that header. If the ARTIFACT_ACCESS_TOKEN is not available, try the GITHUB_TOKEN to avoid the throttling of requests without authorization. It won't work for downloading artifacts, though.
|
Looks fine to me. I think most people that do DLL updates can create branches in the USDX repo anyway? Little bit annoying, but less so than giant git blobs. |
barbeque-squared
merged commit 12448ee
into
UltraStar-Deluxe:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As remarked in #889 (comment) there is a problem when downloading DLLs.
Merge requests from other repositories will not have access to the secret used for the ARTIFACT_ACCESS_TOKEN environment variable. The variable will be set to an empty string. Using an empty token in the Authorization header makes Github reject requests which would be allowed without that header.
If the ARTIFACT_ACCESS_TOKEN is not available, try the GITHUB_TOKEN to avoid the throttling of requests without authorization. It won't work for downloading artifacts, though.