add more functions to use in Lua plugins #554
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extensively use the Lua plugin system to stream (for now only the most important parts of) the user interface over the internet. I would actually like to add much more in the future, but this is a good start, plus this already has some issues that's blocking further development anyway.
The most important changes, and issues with them, are listed below.
array [0..UIni.IMaxPlayerCount-1]
to define the available functionsscore
,sing
orsong
; all others returnunknown
.Notes
, which contains all the useful information, which should probably be flattened.Then there are four last functions (getVisibleSongs, getSelectedIndex, getSongNumbers, getSelectedSong) which:
Please note that my Pascal knowledge is not good enough to be able to improve the shortcomings myself, but maintainers can edit the branch. It's also fine to re-implement this in several commits if that makes it easier, and then just reject this PR.