-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/stim grammar #45
Open
maartenuni
wants to merge
17
commits into
develop
Choose a base branch
from
feature/stim-grammar
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to fill out the stimuli. This does mean, that a GroupList, does not only contain groups, but also elements of WhiteSpace, so the grammar becomes a bit less tidy...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature reworks the way how stimuli are written for the jspsych-spr-reading. Using the javascript nearley parser and moo lexer frameworks it is possible to create a stimulus where you can be more confident how the stimulus will finaly appear on screen. The former stimulus was removing and replacing characters from the input along a number of dimension which made it hard to see what it was doing.
Now there a grammar that dictates how stimuli should be written see plugins/grammar.ne which is converted to plugins/grammar.js. This is all packaged using esbuild to the dist directory. you can call ./build.sh to recreate grammar.js and populate dist. with a packaged version of the plugin.
It is now easier to create a number of bold/italic words in a row as you can put multiple words within tags, whereas before you had to tag each individual word. The grammar is much stricter than a html parser, as groups need to be closed e.g see the readme for more details