Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #239

Merged
merged 5 commits into from
Jan 19, 2025
Merged

fix bug #239

merged 5 commits into from
Jan 19, 2025

Conversation

janez45
Copy link
Contributor

@janez45 janez45 commented Jan 19, 2025

No description provided.

Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/cluster_estimation/cluster_estimation.py Outdated Show resolved Hide resolved
modules/cluster_estimation/cluster_estimation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/cluster_estimation/cluster_estimation.py Outdated Show resolved Hide resolved

max_num_components: int
Max number of real landing pads.
Max number of real landing pads. Must be greater than 0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency: Must be at least 1.

modules/cluster_estimation/cluster_estimation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/cluster_estimation/cluster_estimation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

@janez45 janez45 merged commit 8a3160f into main Jan 19, 2025
1 check passed
@janez45 janez45 deleted the fix-zeros branch January 19, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants