Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved n_components from cluster estimation into config.yml #234

Merged
merged 5 commits into from
Jan 18, 2025
Merged

Moved n_components from cluster estimation into config.yml #234

merged 5 commits into from
Jan 18, 2025

Conversation

lilywang899
Copy link
Contributor

No description provided.

Xierumeng
Xierumeng reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@Xierumeng Xierumeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

modules/cluster_estimation/cluster_estimation.py Outdated Show resolved Hide resolved
modules/cluster_estimation/cluster_estimation.py Show resolved Hide resolved
maxlou05
maxlou05 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@maxlou05 maxlou05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@janez45 janez45 merged commit 8633b43 into main Jan 18, 2025
1 check passed
@janez45 janez45 deleted the max_num_components_config branch January 18, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xierumeng Xierumeng Xierumeng left review comments

@maxlou05 maxlou05 maxlou05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilywang899 @Xierumeng @maxlou05 @janez45