Feature/runtime modification skills list [WIP] #1
+91
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the current state, this PR introduces the |
|
The recent commit seemed to get closer with updating skills in the GUI, however, the |
jsalfity
commented
Oct 4, 2024
| @@ -387,6 +389,14 @@ def __init__(self): | |||
| def _set_debug_cb(self, msg): | |||
| self.publish_runtime_parameters = msg.data | |||
|
|
|||
| def _update_skills_cb(self, _): | |||
| self.sm.skills.clear() | |||
There was a problem hiding this comment.
This is clearing skills form the SkillManager, but it's not clearing skills from the World Model
bchen32
force-pushed
the
feature/runtime_modification_skills_list
branch
from
0983a01
to
c40f0af
Compare
…:UTNuclearRobotics/skiros2 into feature/runtime_modification_skills_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a ROS Service to SkillManagerNode that commands it to reload skills.