Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20231218-1551 #49

Merged
merged 81 commits into from
Dec 19, 2023
Merged

20231218-1551 #49

merged 81 commits into from
Dec 19, 2023

Conversation

UTCGilligan
Copy link
Contributor

@UTCGilligan UTCGilligan commented Dec 18, 2023

For first production deployment. Already deployed to https://gotest.utc.edu.

UTCGilligan and others added 30 commits June 29, 2023 12:30
Signed-off-by: Chris Gilligan <[email protected]>

Package operations: 0 installs, 2 updates, 0 removals
  - Upgrading composer/ca-bundle (1.3.4 => 1.3.6)
  - Upgrading rmccue/requests (v2.0.5 => v2.0.7)
Signed-off-by: Chris Gilligan <[email protected]>
…tend

UTCT-11: Added Sleeky Frontend and Backend Assets.
Signed-off-by: Chris Gilligan <[email protected]>

Secret key was moved to the app config file, not committed, per-environment.
Signed-off-by: Chris Gilligan <[email protected]>

- Ignore tooling and environment-specific config
…ing-assets

UTCT-36: Add Browsersync for frontend dev and update ignores.
UTCT-26: correct frontend ReCaptcha config.
Signed-off-by: Chris Gilligan <[email protected]>
Signed-off-by: Chris Gilligan <[email protected]>

Package operations: 0 installs, 7 updates, 0 removals
  - Upgrading psr/log (1.1.4 => 2.0.0)
  - Upgrading composer/ca-bundle (1.3.6 => 1.3.7)
  - Upgrading rmccue/requests (v2.0.7 => v2.0.9)
  - Upgrading symfony/polyfill-php72 (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-intl-normalizer (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-intl-idn (v1.27.0 => v1.28.0)
  - Upgrading symfony/polyfill-mbstring (v1.27.0 => v1.28.0)
Signed-off-by: Chris Gilligan <[email protected]>
Signed-off-by: Chris Gilligan <[email protected]>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be viewed because one of the lines in the SVG code is too long for Github to parse.

Copy link
Contributor Author

@UTCGilligan UTCGilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's been deployed to https://gotest.utc.edu for review.

@UTCGilligan UTCGilligan marked this pull request as ready for review December 19, 2023 02:01
Copy link
Contributor Author

@UTCGilligan UTCGilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good again. Just a few tweaks to things that nobody has noticed thus far:

  • 1px tweak to height of img.logo on backend
  • Close button styling for the alert when a reserved/used shortcut is tried again

Copy link

@UTCbridget UTCbridget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, Chris! Look forward to seeing in production.

@UTCGilligan UTCGilligan merged commit d9830f5 into main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants