Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login form accessibility #551

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Login form accessibility #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eaadf1d
make form footer link text black
dmnisson Oct 19, 2020
57e1fa9
add alt text to image and make header
dmnisson Oct 19, 2020
becab77
color changes to improve contrast
dmnisson Oct 19, 2020
9e4d045
add nav landmark
dmnisson Oct 19, 2020
730d20a
Merge branch 'master' into login-accessibility
dmnisson Oct 19, 2020
81bee45
lint
dmnisson Oct 19, 2020
0dec005
increase form button font size
dmnisson Oct 19, 2020
87767aa
Merge branch 'login-accessibility' of https://github.com/UPchieve/web…
dmnisson Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FormFooter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default {};
margin-top: auto;

a {
color: #73737a;
color: #000;
text-transform: uppercase;
}

Expand Down
4 changes: 3 additions & 1 deletion src/components/FormPageTemplate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<template>
<div class="FormPageTemplate">
<img class="logo" src="~@/assets/p_logo_white.png" />
<header>
<img class="logo" src="~@/assets/p_logo_white.png" alt="UPchieve" />
</header>
<slot></slot>
</div>
</template>
Expand Down
10 changes: 5 additions & 5 deletions src/scss/layout/_form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

&--active {
@extend #{$className};
color: $c-accent;
color: $c-shadow;
}
}

Expand Down Expand Up @@ -106,12 +106,12 @@
}

.uc-form-button {
background-color: #f6f6f6;
border: none;
background-color: white;
border: 1px solid $c-accent;
border-radius: 20px;
color: $c-accent;
color: scale-color($c-accent, $lightness: -60%);

font-size: 12px;
font-size: 16px;
font-weight: 600;
text-transform: uppercase;

Expand Down
10 changes: 6 additions & 4 deletions src/views/LoginView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<template>
<form-page-template>
<form class="uc-form">
<div class="uc-form-header">
<div class="uc-form-header-link--active">Log In</div>
<form class="uc-form" aria-labelledby="loginFormHeader">
<nav class="uc-form-header">
<div class="uc-form-header-link--active" id="loginFormHeader">
Log In
</div>
<router-link to="/sign-up" class="uc-form-header-link"
>Sign Up</router-link
>
</div>
</nav>

<div class="uc-form-body">
<div
Expand Down