control folder, controller package, common launch file #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanish29
requested changes
Nov 19, 2024
| 'pure_pursuit = controller.pure_pursuit_controller.main', | ||
| ], | ||
| }, | ||
| data_files=[ |
There was a problem hiding this comment.
have you tested having 2 "data_files" works?
| executable=controller_type, #reference the controller name passed as argument | ||
| name=controller_type, # Node name matches the controller name | ||
| output='screen', | ||
| parameters=[{'controller_type': controller_type}] |
There was a problem hiding this comment.
the parameters argument is if the controller_type node has parameters. Is controller_type a parameter in the node?
Everything else looks good, nice!
| @@ -0,0 +1,15 @@ | |||
| from launch import LaunchDescription | |||
There was a problem hiding this comment.
why is the Stanley controller here if it's copied to the controller package?
There was a problem hiding this comment.
This should be deleted
Zane-Larking
requested changes
Dec 2, 2024
| @@ -0,0 +1,15 @@ | |||
| from launch import LaunchDescription | |||
There was a problem hiding this comment.
This should be deleted
There was a problem hiding this comment.
There are some missing dependencies:
ackermann_msgs
moa_msgs
geometry_msgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description