Fix payment processor

[LEAD-Anoy74]

Fix payment processor for all coins.

[mooleshacat]

Looks good 👍

[ahmedbodi]

Whys this changed?

[LEAD-Anoy74]

That portion of code doesn't even make sense to exist anymore, since miners should be allowed to setup a longer .workername.

It's also broken, and doesn't even change the address to poolconfig pooladdrress.

Cheers

[mooleshacat]

I agree partially with @LEAD-Anoy74 on the issue of the length should not even be checked.

The function is not meant to change the address at all... It is meant to check the address if it is valid and matches pool configuration.

Most pools accept WALLET.WORKER format and the workername can be any length (unless pool limits it)

What I would do is split the address / worker name and then do the length check after, or just rip it out alltogether.

Either use:

var getProperAddress = function(address){

    var splitted_address = [address].toString();
    splitted_address = splitted_address.split('.',1);

    if (splitted_address.length === 60){
            return util.addressFromEx(poolOptions.address, splitted_address);
    fi
    else return splitted_address;

}

or use this:

var getProperAddress = function(address){

    return util.addressFromEx(poolOptions.address, address);

}

I would personally modify the function and add more sanity / validation checks.

For example:

• Add in a check to make sure there are no symbols inside the string containing the address/worker name (except for the '.' separating the two)
• Add a validateaddress RPC call to check the address is valid
• Use the same validateaddress RPC call results to check the address is owned by the pool daemon

[LEAD-Anoy74]

Correct

[ahmedbodi]

The spacing of this is all over the place, but from a quick skim, the function can be kept the same by splitting the address before its passed into getProperAddress. The purpose of this function is as a sanity check to ensure that only a valid base58 bitcoin-type address is passed in and used from that point forward. This change would be breaking that check.