Refactor Express module initialization: remove unnecessary promise in…

… init method and update Server class to call init without await
UKDanceBlue · Jan 17, 2025 · 6017c87 · 6017c87
1 parent 1519134
commit 6017c87
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/packages/server/src/entry/server/Express.ts b/packages/server/src/entry/server/Express.ts
@@ -43,14 +43,11 @@ export class ExpressModule {
     private readonly cookieSecret: string
   ) {}
 
-  async init(): Promise<void> {
+  init() {
     this.#app = express();
     this.#app.set("trust proxy", true);
 
     this.#httpServer = http.createServer(this.app);
-
-    // eslint-disable-next-line unicorn/no-useless-promise-resolve-reject
-    return Promise.resolve();
   }
 
   public startMiddlewares() {

diff --git a/packages/server/src/entry/server/Server.ts b/packages/server/src/entry/server/Server.ts
@@ -41,7 +41,7 @@ export class Server implements EntryPoint {
       `Logger initialized with level "${this.loggingLevel}", writing log files to "${this.logDir}"`
     );
 
-    await this.expressModule.init();
+    this.expressModule.init();
     await this.apolloModule.init();
 
     this.expressModule.startMiddlewares();