Skip to content

Commit

Permalink
Merge branch 'sam-wouters-master'
Browse files Browse the repository at this point in the history
  • Loading branch information
jhoblitt committed Jun 7, 2015
2 parents 357b821 + 42e0b46 commit e3eaf0a
Show file tree
Hide file tree
Showing 10 changed files with 37 additions and 18 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ file (one without any fragments).

* el6.x
* el5.x
* el7.x
* Debian/Ubuntu

### Puppet Version Compatibility
Expand Down
15 changes: 10 additions & 5 deletions manifests/params.pp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

case $::osfamily {
'debian': {
$udev_package = 'udev'
$udev_package = 'udev'
$udevlogpriority = 'udevadm control --log-priority'
$udevtrigger = 'udevadm trigger'
}
Expand All @@ -23,13 +23,18 @@
}
} else {
case $::operatingsystemmajrelease {
'5': {
$udev_package = 'udev'
5: {
$udev_package = 'udev'
$udevtrigger = 'udevtrigger'
$udevlogpriority = 'udevcontrol log_priority'
}
'6','7': {
$udev_package = 'udev'
6: {
$udev_package = 'udev'
$udevtrigger = 'udevadm trigger'
$udevlogpriority = 'udevadm control --log-priority'
}
7: {
$udev_package = 'systemd'
$udevtrigger = 'udevadm trigger'
$udevlogpriority = 'udevadm control --log-priority'
}
Expand Down
2 changes: 1 addition & 1 deletion manifests/udevadm/trigger.pp
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@

exec { $udev::params::udevtrigger:
refreshonly => true,
path => [$udev::params::udevadm_path],
path => $udev::params::udevadm_path,
}
}
9 changes: 6 additions & 3 deletions metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,24 @@
"operatingsystem": "RedHat",
"operatingsystemrelease": [
"5",
"6"
"6",
"7"
]
},
{
"operatingsystem": "CentOS",
"operatingsystemrelease": [
"5",
"6"
"6",
"7"
]
},
{
"operatingsystem": "Scientific",
"operatingsystemrelease": [
"5",
"6"
"6",
"7"
]
},
{
Expand Down
12 changes: 11 additions & 1 deletion spec/acceptance/udev_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
require 'spec_helper_acceptance'

describe 'udev class' do
maj = fact_on 'master', 'operatingsystemmajrelease'

package_name = nil
case maj.to_i
when 5, 6
package_name = 'udev'
when 7
package_name = 'systemd'
end

describe 'running puppet code' do
it 'should work with no errors' do
pp = <<-EOS
Expand All @@ -21,7 +31,7 @@ class { 'udev': udev_log => 'debug' }
end
end

describe package('udev') do
describe package(package_name) do
it { should be_installed }
end

Expand Down
4 changes: 2 additions & 2 deletions spec/classes/params_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
let :facts do
{
:osfamily => 'RedHat',
:operatingsystemmajrelease => '6',
:operatingsystemmajrelease => 6,
}
end

Expand All @@ -17,7 +17,7 @@
let :facts do
{
:osfamily => 'RedHat',
:operatingsystemmajrelease => '4',
:operatingsystemmajrelease => 4,
}
end

Expand Down
2 changes: 1 addition & 1 deletion spec/classes/udev_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
let :facts do
{
:osfamily => 'RedHat',
:operatingsystemmajrelease => '6',
:operatingsystemmajrelease => 6,
}
end

Expand Down
4 changes: 2 additions & 2 deletions spec/classes/udevadm/logpriority_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
describe 'for osfamily RedHat and operatingsystemmajrelease 6' do
let(:facts) do
{ :osfamily => 'RedHat',
:operatingsystemmajrelease => '6',
:operatingsystemmajrelease => 6,
}
end

Expand Down Expand Up @@ -66,7 +66,7 @@
describe 'for osfamily RedHat and operatingsystemmajrelease 5' do
let(:facts) do
{ :osfamily => 'RedHat',
:operatingsystemmajrelease => '5',
:operatingsystemmajrelease => 5,
}
end

Expand Down
4 changes: 2 additions & 2 deletions spec/classes/udevadm/trigger_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
describe 'for osfamily RedHat' do
let(:facts) do
{ :osfamily => 'RedHat',
:operatingsystemmajrelease => '6',
:operatingsystemmajrelease => 6,
}
end

Expand All @@ -21,7 +21,7 @@
describe 'for osfamily RedHat' do
let(:facts) do
{ :osfamily => 'RedHat',
:operatingsystemmajrelease => '5',
:operatingsystemmajrelease => 5,
}
end

Expand Down
2 changes: 1 addition & 1 deletion spec/defines/rule_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
let :facts do
{
:osfamily => 'RedHat',
:operatingsystemmajrelease => '6',
:operatingsystemmajrelease => 6,
}
end

Expand Down

0 comments on commit e3eaf0a

Please sign in to comment.