Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line switch for detect deployment type #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TrueWill
Copy link
Contributor

@TrueWill TrueWill commented May 7, 2019

Specifying -d or --detect-deploy on the command line will cause mulint to detect the deployment type (on-prem or CloudHub). This is the current behavior. Omitting that means that mulint will assume on-prem deployment.

@TrueWill TrueWill self-assigned this May 7, 2019
@TrueWill TrueWill requested a review from UKachegere May 7, 2019 19:20
@TrueWill TrueWill added the enhancement New feature or request label May 7, 2019
Copy link

@UKachegere UKachegere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueWill
I am not sure -d option is the right way to go if you would like this to work it for any deployment type ie on-prem or cloud. Making an assumption that it is on-prem might work for UFG's setup. It might not work for companies having all cloudhub deployments.

Would throwing error and stop processing when "mule-maven-plugin" is present and any deployment information is not in the pom file? If we are using Anypoint CLI and not using Maven plugin to deploy, none of those information should be in the POM file and needs to be removed.

Hope this make sense. Let me know if you have questions

@TrueWill
Copy link
Contributor Author

TrueWill commented May 7, 2019

@UKachegere My thought was that UFG would run mulint without the switch, so it would default to on-prem. Other companies could run mulint with the switch, and it would look at the deployment.type in the POM. Alternately they could open a PR to add a --cloudhub switch that would default to CloudHub.

We can either error (fatal) or warn on any condition you like. I just need to know what the conditions are and the severity.

@TrueWill
Copy link
Contributor Author

@UKachegere Please let me know if you'd like me to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants