Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XML parsing error messages #38

Merged
merged 10 commits into from
Nov 6, 2018
Merged

Conversation

TrueWill
Copy link
Contributor

@TrueWill TrueWill commented Nov 2, 2018

Include the filename in XML parsing errors.

Centralize parsing of XML.

Specify the encoding when reading text files. (See https://stackoverflow.com/questions/6456864/why-does-node-js-fs-readfile-return-a-buffer-instead-of-string)

This addresses the latter part of #37

Previous output when there was an XML parsing error:

[error]  Error: Unexpected close tag
Line: 69
Column: 7
Char: >

1 problem found (1 error, 0 warnings)

New output:

[error]  Unable to parse XML file "C:\SourceCode\mulesoft-apis\System APIs\wsflx-system-api\impl\wsflx-system-api\src\main\app\global.xml": Error: Unexpected close tag
Line: 69
Column: 7
Char: >

1 problem found (1 error, 0 warnings)

@TrueWill TrueWill added the bug Something isn't working label Nov 2, 2018
@TrueWill TrueWill self-assigned this Nov 2, 2018
@TrueWill
Copy link
Contributor Author

TrueWill commented Nov 6, 2018

Rebased

@TrueWill TrueWill merged commit ee505b3 into master Nov 6, 2018
@TrueWill TrueWill deleted the fix/parse-error-messages branch November 6, 2018 20:35
@TrueWill TrueWill mentioned this pull request Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants