Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nbconvert #214

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Update nbconvert #214

merged 4 commits into from
Oct 4, 2022

Conversation

ageorgou
Copy link
Contributor

@ageorgou ageorgou commented Oct 4, 2022

Fixes #186.

  • Update nbconvert dependency (and related jinja2 change from Update for move to ARC and CS #213)
  • Remove "widgets" metadata from notebooks. This was only present in some notebooks, and caused issues with newer nbconvert (but not on all notebooks where it was used!). I don't think it affects anything.
  • Update our custom templates to work with the new style introduced in nbconvert 6: the Jekyll template should be okay, I haven't tried the LaTeX one.

This caused issues with newer nbconvert on some files. I don't
see any noticeable differences in the output, apart from figures
being a bit bigger. Changing it on all files where it appears,
for consistency.
@ageorgou ageorgou requested a review from dpshelio October 4, 2022 14:13
@dpshelio dpshelio merged commit ee705bc into main Oct 4, 2022
@dpshelio dpshelio deleted the new-template-style branch October 4, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build breaks for newest nbconvert
2 participants