-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Changing references to PNG image to JPEG image and removing use of BytesIO in reading images from bytes.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -11,7 +11,7 @@ | |||
"cell_type": "markdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way removed the only docstring we had? Yeah, weird we have only one... but it may be the useful one.
Also, on step
the two print
s were to distinguish before from after. Maybe the print
in the middle could be added with a separator, like a ------
or something.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I partly removed as it the previous docstring was using a plain string "..."
rather than a multiline string """..."""
, which while allowed and a valid docstring, is non-conventional . We also don't introduce docstrings previously at all I think so having one single example here without explanation I feel is more hindrance than help as I don't think it's clear this is a docstring and its not obvious why we would choose to add only this method. I've now updated to add docstrings to all the methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good!! Some small comments left on the reviewNB. But approving it so you can merge it straight away if you use these suggestions.
Thanks for the review and suggestions! Now made changes to address all of the comments. |
Build website job is failing with error
which seems to be as the current version of I will try pinning to a newer version with the fixed included. |
In the end trying to use an updated |
Updates to the notebooks performed before last run of 'novice' course in February 2022
000Exemplar.ipynb
notebook changes incorrect references to PNG image to JPEG image and removes use ofBytesIO
in reading images from bytes.010Internet.ipynb
notebook updates Google Maps URLs due to deprecation of previous API, adds more detail to description of URI scheme, minor updates to example usages of Requests library.020TabularData.ipynb
notebook adds extra description of tabular data formats and delimter-separated value files specifically and switches to using in-builtcsv
module to read CSV rather than NumPy to avoid having to explain NumPy concepts before main NumPy introduction.030StructuredData.ipynb
removes!pip install pyyaml
shell command in notebook to avoid OS compatibility issues and added exemplar maze structure from beginners course exercise for final exercise to allow for students who haven't done beginners course and so don't have own definition.070Classes.ipynb
small tweaks to remove explicit subclassing fromobject
, use format strings rather than string concatenation and improve formatting of code / Markdown text.Makefile
updates to list of files to clean to reflect new names.