Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of model_typed and model_warntype in DebugUtils #708

Merged
merged 21 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9f392a7
added InteractiveUtils.jl as a dep + `model_typed` and
torfjelde Oct 31, 2024
68295e8
Apply suggestions from code review
torfjelde Oct 31, 2024
6a42613
added `optimize` kwarg to `model_typed` and `model_warntype`
torfjelde Nov 4, 2024
b60aaec
Merge remote-tracking branch 'origin/torfjelde/code-warntype' into to…
torfjelde Nov 4, 2024
a6584c4
formatting
torfjelde Nov 4, 2024
076aee5
expanded docstring for `model_warntype` and `model_codetyped` and
torfjelde Nov 5, 2024
52b4301
added testing for `model_codetyped` and `model_warntype`
torfjelde Nov 5, 2024
bc43b98
Merge remote-tracking branch 'origin/torfjelde/code-warntype' into to…
torfjelde Nov 5, 2024
4794c4f
bump patch version
torfjelde Nov 5, 2024
2925ee1
Merge branch 'master' into torfjelde/code-warntype
torfjelde Nov 5, 2024
afdcd82
added tests for `model_codetyped` and `model_warntype` for model with
torfjelde Nov 5, 2024
5519a83
added test/debug_utils.jl to test/runtests.jl
torfjelde Nov 5, 2024
6b6c7dd
renamed `model_codetyped` to `model_typed` to be consistent with the
torfjelde Nov 5, 2024
0fc3c1e
Merge branch 'master' into torfjelde/code-warntype
torfjelde Nov 6, 2024
fb5f644
avoid usage of macros within `model_warntype` and `model_typed` due
torfjelde Nov 8, 2024
cf750e1
formatting
torfjelde Nov 11, 2024
f6115c7
renamed `_make_evaluate_args_and_kwargs` to
torfjelde Nov 11, 2024
c794ff4
Merge branch 'master' into torfjelde/code-warntype
torfjelde Nov 11, 2024
c6c35d8
formatting
torfjelde Nov 11, 2024
4f882a7
bump patch version
torfjelde Nov 11, 2024
7f2863b
Update src/debug_utils.jl
torfjelde Nov 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
LogDensityProblems = "6fdf6af0-433a-55f7-b3ed-c6c6e0b8df7c"
LogDensityProblemsAD = "996a588d-648d-4e1f-a8f0-a84b347e47b1"
Expand Down
41 changes: 41 additions & 0 deletions src/debug_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

using Random: Random
using Accessors: Accessors
using InteractiveUtils: InteractiveUtils

using DocStringExtensions
using Distributions
Expand Down Expand Up @@ -678,4 +679,44 @@
return all_the_same(transforms)
end

"""
model_warntype(model[, varinfo, context])

Check the type stability of the model's evaluator, warning about any potential issues.

This simply calls `@code_warntype` on the model's evaluator, filling in internal arguments where needed.
"""
function model_warntype(

Check warning on line 689 in src/debug_utils.jl

View check run for this annotation

Codecov / codecov/patch

src/debug_utils.jl#L689

Added line #L689 was not covered by tests
willtebbutt marked this conversation as resolved.
Show resolved Hide resolved
model::Model,
varinfo::AbstractVarInfo=VarInfo(model),
context::AbstractContext=DefaultContext(),
)
args, kwargs = DynamicPPL.make_evaluate_args_and_kwargs(model, varinfo, context)
return if isempty(kwargs)
InteractiveUtils.@code_warntype model.f(args...)

Check warning on line 696 in src/debug_utils.jl

View check run for this annotation

Codecov / codecov/patch

src/debug_utils.jl#L694-L696

Added lines #L694 - L696 were not covered by tests
else
InteractiveUtils.@code_warntype model.f(args...; kwargs...)

Check warning on line 698 in src/debug_utils.jl

View check run for this annotation

Codecov / codecov/patch

src/debug_utils.jl#L698

Added line #L698 was not covered by tests
end
end

"""
willtebbutt marked this conversation as resolved.
Show resolved Hide resolved
model_typed(model[, varinfo, context])

Return the type inference for the model's evaluator.

This simply calls `@code_typed` on the model's evaluator, filling in internal arguments where needed.
"""
function model_typed(

Check warning on line 709 in src/debug_utils.jl

View check run for this annotation

Codecov / codecov/patch

src/debug_utils.jl#L709

Added line #L709 was not covered by tests
model::Model,
varinfo::AbstractVarInfo=VarInfo(model),
context::AbstractContext=DefaultContext(),
)
args, kwargs = DynamicPPL.make_evaluate_args_and_kwargs(model, varinfo, context)
return if isempty(kwargs)
InteractiveUtils.@code_typed model.f(args...)

Check warning on line 716 in src/debug_utils.jl

View check run for this annotation

Codecov / codecov/patch

src/debug_utils.jl#L714-L716

Added lines #L714 - L716 were not covered by tests
else
InteractiveUtils.@code_typed model.f(args...; kwargs...)

Check warning on line 718 in src/debug_utils.jl

View check run for this annotation

Codecov / codecov/patch

src/debug_utils.jl#L718

Added line #L718 was not covered by tests
end
end

end
Loading