Fix ominous item spawners not being parsed

- Fixed ominous item spawners not being parsed for light emitting items
- Fixed tschipcraft.menu trigger not being enabled in 1.21+
- Updated GitHub workflow to annotate snapshot level and Java 21 support

.github/workflows/cd.yml

@@ -9,11 +9,11 @@ on:
       mc_version:
         description: 'Minecraft version(s) the data pack runs in (human readable)'
         required: true
-        default: '1.17x-1.20x'
+        default: '1.17x-1.21x'
       mc_version_range:
         description: 'Minecraft version(s) the data pack runs in (encoded in version range spec)'
         required: true
-        default: '>=1.17 <=1.20.4'
+        default: '>=1.17 <=1.21'
 
 jobs:
   deploy:
@@ -91,6 +91,7 @@ jobs:
           modrinth-id: 7YjclEGc
           modrinth-token: ${{ secrets.MODRINTH_TOKEN }}
           game-versions: ${{ github.event.inputs.mc_version_range }}
+          game-version-filter: any
           fail-mode: skip
 
           name: "[DP] Release v${{ github.event.inputs.tag }}"
@@ -109,6 +110,7 @@ jobs:
           modrinth-id: 7YjclEGc
           modrinth-token: ${{ secrets.MODRINTH_TOKEN }}
           game-versions: ${{ github.event.inputs.mc_version_range }}
+          game-version-filter: any
           fail-mode: skip
 
           name: "[Mod] Release v${{ github.event.inputs.tag }}"
@@ -134,6 +136,7 @@ jobs:
           curseforge-id: 831385
           curseforge-token: ${{ secrets.CURSEFORGE_TOKEN }}
           game-versions: ${{ github.event.inputs.mc_version_range }}
+          game-version-filter: any
           fail-mode: skip
 
           name: "Release v${{ github.event.inputs.tag }}"
@@ -152,6 +155,7 @@ jobs:
           curseforge-id: 910095
           curseforge-token: ${{ secrets.CURSEFORGE_TOKEN }}
           game-versions: ${{ github.event.inputs.mc_version_range }}
+          game-version-filter: any
           fail-mode: skip
 
           name: "Release v${{ github.event.inputs.tag }}"
@@ -163,6 +167,7 @@ jobs:
             catalogue-fabric(optional){curseforge:667377}
             midnightlib(optional){curseforge:488090}
           java: |
+            Java 21
             Java 17
             Java 18
           loaders: |

data/dynamiclights/function/install.mcfunction

@@ -59,6 +59,7 @@ execute unless score $rain_sensitive ts.dl.settings matches -1..2 run scoreboard
 execute unless score $unlimited ts.dl.settings matches -1..2 run scoreboard players set $unlimited ts.dl.settings 0
 
 scoreboard objectives add tschipcraft.menu trigger
+scoreboard players enable @a tschipcraft.menu
 
 scoreboard objectives add tvc_ignore dummy
 

data/dynamiclights/function/internal/sources/parse/main.mcfunction

@@ -5,6 +5,7 @@ summon armor_stand ~ ~ ~ {UUID:[I;-1030365714,1276464731,-2084950084,-395075115]
 # Copy NBT data
 execute as @s[type=minecraft:falling_block] run data modify entity c295ddee-4c15-4e5b-83ba-2fbce873a1d5 HandItems[0].id set from entity @s BlockState.Name
 execute as @s[type=minecraft:block_display] run data modify entity c295ddee-4c15-4e5b-83ba-2fbce873a1d5 HandItems[0].id set from entity @s block_state.Name
+execute as @s[type=minecraft:ominous_item_spawner] run data modify entity c295ddee-4c15-4e5b-83ba-2fbce873a1d5 HandItems[0] set from entity @s item
 
 execute as c295ddee-4c15-4e5b-83ba-2fbce873a1d5 run function dynamiclights:internal/sources/parse/main_exec
 

data/dynamiclights/function/reset.mcfunction

@@ -10,6 +10,7 @@ function dynamiclights:internal/explosion_detection/reset
 
 # Reset advancement
 advancement revoke @a only tschipcraft:menu
+scoreboard players enable @a tschipcraft.menu
 
 # Reschedule main function
 schedule function dynamiclights:internal/main 5t

data/dynamiclights/tags/entity_type/parse.json

@@ -4,6 +4,7 @@
   "replace": false,
   "values": [
     "minecraft:falling_block",
-    {"id": "minecraft:block_display", "required": false}
+    {"id": "minecraft:block_display", "required": false},
+    {"id": "minecraft:ominous_item_spawner", "required": false}
   ]
 }

data/dynamiclights/tags/entity_type/single_slot_entities.json

@@ -7,7 +7,6 @@
     "minecraft:item",
     "minecraft:item_display",
     "minecraft:item_frame",
-    "minecraft:glow_item_frame",
-    {"id": "minecraft:ominous_item_spawner", "required": false}
+    "minecraft:glow_item_frame"
   ]
 }

overlay_35/data/dynamiclights/functions/internal/sources/parse/main.mcfunction

@@ -5,6 +5,7 @@ summon armor_stand ~ ~ ~ {UUID:[I;-1030365714,1276464731,-2084950084,-395075115]
 # Copy NBT data
 execute as @s[type=minecraft:falling_block] run data modify entity c295ddee-4c15-4e5b-83ba-2fbce873a1d5 HandItems[0].id set from entity @s BlockState.Name
 execute as @s[type=minecraft:block_display] run data modify entity c295ddee-4c15-4e5b-83ba-2fbce873a1d5 HandItems[0].id set from entity @s block_state.Name
+execute as @s[type=minecraft:ominous_item_spawner] run data modify entity c295ddee-4c15-4e5b-83ba-2fbce873a1d5 HandItems[0] set from entity @s item
 
 execute as c295ddee-4c15-4e5b-83ba-2fbce873a1d5 run function dynamiclights:internal/sources/parse/main_exec
 

overlay_35/data/dynamiclights/tags/entity_types/parse.json

@@ -4,6 +4,7 @@
   "replace": false,
   "values": [
     "minecraft:falling_block",
-    {"id": "minecraft:block_display", "required": false}
+    {"id": "minecraft:block_display", "required": false},
+    {"id": "minecraft:ominous_item_spawner", "required": false}
   ]
 }

overlay_35/data/dynamiclights/tags/entity_types/single_slot_entities.json

@@ -7,7 +7,6 @@
     "minecraft:item",
     "minecraft:item_display",
     "minecraft:item_frame",
-    "minecraft:glow_item_frame",
-    {"id": "minecraft:ominous_item_spawner", "required": false}
+    "minecraft:glow_item_frame"
   ]
 }