Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opt-in ghost service to docker compose #21938

Merged

Conversation

cmraible
Copy link
Collaborator

@cmraible cmraible commented Dec 20, 2024

ref https://linear.app/ghost/issue/ENG-1957/add-ghost-service-to-base-docker-compose-setup

  • Currently our compose.yml file only runs Ghost's supporting services, and it's expected that you'll run Ghost locally on your host machine. This commit adds a ghost service to our compose.yml file, so you can optionally run Ghost itself in a container using docker compose.
  • The ghost service is opt-in using docker compose profiles, to maintain the current behavior of only running supporting services as the default.
  • This commit also fixes an issue in the Dockerfile: the WORKDIR arg, which is used to optionally specify an alternative working directory, is not propagated from one build stage to the next, so it has to be manually added as an ARG in each stage. This was necessary to use the same Dockerfile for devcontainers (which require the WORKDIR to be /workspaces/ghost) and docker compose, where we use /home/ghost in alignment with the production image.

@cmraible cmraible changed the title WIP: Added ghost service to base docker compose setup Added ghost service to docker compose Jan 7, 2025
@cmraible cmraible force-pushed the chris-eng-1957-add-ghost-service-to-base-docker-compose-setup branch from 75638de to 2cf9470 Compare January 7, 2025 20:51
@cmraible cmraible marked this pull request as ready for review January 7, 2025 21:55
@cmraible cmraible changed the title Added ghost service to docker compose Added opt-in ghost service to docker compose Jan 7, 2025
@cmraible cmraible merged commit c1f9740 into main Jan 7, 2025
18 checks passed
@cmraible cmraible deleted the chris-eng-1957-add-ghost-service-to-base-docker-compose-setup branch January 7, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant