2 additional AI turn actions #718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is supposed to be a faster version of AI_TurnToNpc and seemlingly used in Gothic 1 in a number of places. The script does not contain specific values for whirl-speed, so just use double of the NPc's turn-speed. This looked quite nice with the guards at the New Camp when drawing a weapon behind them.
Defined as 'npc' turns away from 'other', just like turnTo but +180 degrees. One user is for example the crazy Baal Netbek in the swamp where the player character ends the dialog with turning away saying "This guy won't be of help"
Try
reviewed
Jan 15, 2025
| auto dx = oth.x-x; | ||
| auto dz = oth.z-z; | ||
| auto gl = guild(); | ||
| float step = float(owner.script().guildVal().turn_speed[gl]) * 2; |
There was a problem hiding this comment.
Based on video evidence you shared previously:
https://youtu.be/GKpt0Y07gJw?t=1538 ... when talking to Xardas' daemon, which is this sequence from above
Rotation speed appears(not 100% sure) to be the same, but with different animation.
There was a problem hiding this comment.
Ahhhh ... you're right ... thanks for noticing that discrepancy.
Digging deeper, the animation data does have t_surprise_ccw and t_surprise_cw states and G1 data comes uncompiled with "//WhirlAround" comments intact above those :-) .
Additionally, it looks like in G1 everybody including humans have the whirl animation, where in G2, monsters have it - including the newly added ones - but not humans.
So I'll continue digging :-) .
Try
reviewed
Jan 15, 2025
| break; | ||
| } | ||
| // Not looking quite correct in dialogs, when npc turns around | ||
| // Example: Esteban dialog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI_WhirlAround is doing the same as ai_turntonpc, just faster.
The script does not contain specific values for whirl-speed, so just use
double of the NPc's turn-speed.
AI_turnaway does what the name implies and turns the back to the npc.
There might be a nicer way to calculate that angle than in my code.