forked from Amit86/minimanager
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility and security issues [BREAKING CHANGE] #76
Merged
Aokromes
merged 15 commits into
TrinityCore:master
from
flashadvocate:accessibility_security_issues
Dec 27, 2022
Merged
Accessibility and security issues [BREAKING CHANGE] #76
Aokromes
merged 15 commits into
TrinityCore:master
from
flashadvocate:accessibility_security_issues
Dec 27, 2022
Commits on Dec 27, 2022
-
and titles to hidden submit buttons. Also omit empty values from submit buttons.
Configuration menu - View commit details
-
Copy full SHA for d255b6f - Browse repository at this point
Copy the full SHA d255b6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f0e3a6 - Browse repository at this point
Copy the full SHA 9f0e3a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 743840b - Browse repository at this point
Copy the full SHA 743840bView commit details -
Dropping these in favor of server-side redirects. Providing a "oops, you aren't supposed to be here" simply exposes directory structure to the end user. Ideally, apache/nginx should forward all requests to a front controller (index.php) and handle routing at the application layer. Navigating directly to individual PHP files makes it hard to obscure details about the application.
Configuration menu - View commit details
-
Copy full SHA for f7a6447 - Browse repository at this point
Copy the full SHA f7a6447View commit details -
Prevent access to included config file
Though it is PHP and thus will render nothing in the browser, we don't want to expose its existence. There's also a possibility that, given a broken or misconfigured state, this file could output its contents
Configuration menu - View commit details
-
Copy full SHA for 8713688 - Browse repository at this point
Copy the full SHA 8713688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1278c29 - Browse repository at this point
Copy the full SHA 1278c29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a90da5 - Browse repository at this point
Copy the full SHA 8a90da5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dec5ce9 - Browse repository at this point
Copy the full SHA dec5ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d52e70 - Browse repository at this point
Copy the full SHA 2d52e70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53314d2 - Browse repository at this point
Copy the full SHA 53314d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b8e303 - Browse repository at this point
Copy the full SHA 6b8e303View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85fb4a5 - Browse repository at this point
Copy the full SHA 85fb4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfe1212 - Browse repository at this point
Copy the full SHA cfe1212View commit details -
Configuration menu - View commit details
-
Copy full SHA for aec2d0a - Browse repository at this point
Copy the full SHA aec2d0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ded57e6 - Browse repository at this point
Copy the full SHA ded57e6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.