Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and security issues [BREAKING CHANGE] #76

Merged
merged 15 commits into from
Dec 27, 2022
Merged

Accessibility and security issues [BREAKING CHANGE] #76

merged 15 commits into from
Dec 27, 2022

Commits on Dec 27, 2022

  1. Add labels to login form

    and titles to hidden submit buttons. Also omit empty values from submit buttons.
    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    d255b6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f0e3a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    743840b View commit details
    Browse the repository at this point in the history
  4. Replace index.html

    Dropping these in favor of server-side redirects. Providing a "oops, you aren't supposed to be here" simply exposes directory structure to the end user.
    
    Ideally, apache/nginx should forward all requests to a front controller (index.php) and handle routing at the application layer. Navigating directly to individual PHP files makes it hard to obscure details about the application.
    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    f7a6447 View commit details
    Browse the repository at this point in the history
  5. Prevent access to included config file

    Though it is PHP and thus will render nothing in the browser, we don't want to expose its existence.
    
    There's also a possibility that, given a broken or misconfigured state, this file could output its contents
    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    8713688 View commit details
    Browse the repository at this point in the history
  6. Revert session option

    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    1278c29 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8a90da5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dec5ce9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2d52e70 View commit details
    Browse the repository at this point in the history
  10. Fix merge conflicts

    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    53314d2 View commit details
    Browse the repository at this point in the history
  11. Drop IDE artifact (#77)

    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    6b8e303 View commit details
    Browse the repository at this point in the history
  12. removed outdated information.

    Aokromes authored and flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    85fb4a5 View commit details
    Browse the repository at this point in the history
  13. Fix merge conflict

    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    cfe1212 View commit details
    Browse the repository at this point in the history
  14. Add documentation notes

    flashadvocate committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    aec2d0a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ded57e6 View commit details
    Browse the repository at this point in the history