-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically trigger autocomplete on focus. #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SiriusXT , although an interesting contribution, there are two downsides to this approach that I can notice:
- There is a short blink between adding a new tab and the popup showing.
- If there are multiple workspaces, the workspace switcher which resides just under the search bar is completely covered.
- This means that a user has to press Escape or click outside to hide the popup, resulting in one extra action that needs to be done in order to switch workspaces.
- I think this one can be mitigated by either moving the workspace switcher above the search box or using a list-based approach for autocompletion (similar to how I implemented the jump-to-note one).
- The biggest issue is that new users who are not aware that there is a workspace switcher underneath the auto-triggered completion will not discover it easily.
Whilst the first one is not that important, the second one would be a deal-breaker.
|
Automatically trigger autocomplete on focus, which can achieve: