Introduce stable tag on containers
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliandoran
reviewed
Oct 14, 2024
.github/workflows/main-docker.yml
Outdated
Comment on lines
246
to
255
| # If the ref is a tag, also tag the image as stable as this is part of a 'release' | ||
| if [[ "${GITHUB_REF}" == refs/tags/* ]]; then | ||
| docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \ | ||
| -t ${{ env.GHCR_REGISTRY }}/${{ env.IMAGE_NAME }}:stable \ | ||
| $(printf '${{ env.GHCR_REGISTRY }}/${{ env.IMAGE_NAME }}@sha256:%s ' *) | ||
|
|
||
| docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \ | ||
| -t ${{ env.DOCKERHUB_REGISTRY }}/${{ env.IMAGE_NAME }}:stable \ | ||
| $(printf '${{ env.DOCKERHUB_REGISTRY }}/${{ env.IMAGE_NAME }}@sha256:%s ' *) | ||
| fi |
There was a problem hiding this comment.
You did quite a bit of bash magic in here. 😎
Does this also handle the case where I push a beta version such as v0.90.7-beta? In this case we shouldn't tag it as stable; the stable tag should remain to v0.90.4 until say v0.90.8 comes along.
There was a problem hiding this comment.
Yeah Bash is not my favorite, but it's a power I have lol - and no, that's a good point. I was just catching if there was a new tag pushed. I'm assuming I would just have to catch if there is a - in the string of the tag that is pushed, to assume that it's not a stable build?
e.g. don't mark these as stable:
v1.0.0-alpha
v2.24.1-beta
etc...
perfectra1n
commented
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #488