Port frontend to TypeScript (0% -> 38.2%) #273
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliandoran
commented
Jul 24, 2024
•
eliandoran
commented
| Language | files | blank | comment | code |
|---|---|---|---|---|
| JavaScript | 259 | 5819 | 1425 | 23855 |
| TypeScript | 31 | 992 | 397 | 14751 |
| -------- | -------- | -------- | -------- | -------- |
| SUM: | 290 | 6811 | 1822 | 38606 |
…escript_port1 ; Conflicts: ; package-lock.json
eliandoran
changed the title
eliandoran
force-pushed
the
develop
branch
2 times, most recently
from
88ea25a
to
5295d95
Compare
|
Hey Elian whats the relation between this and #157? I wanted to dive in to either reviewing or helping convert but not sure where I should be looking. |
|
@rauenzi ,
#157 is the first attempt. This is a rewrite of the same modifications as #157 but without separating the client/server architecture. So if you have time, feel free to start with this PR. I'll close the old one. |
|
Gotcha, thanks for clarifying, I'll start here then! |
eliandoran
force-pushed
the
develop
branch
3 times, most recently
from
eff61af
to
4090386
Compare
eliandoran
force-pushed
the
develop
branch
5 times, most recently
from
baa17c3
to
42c7148
Compare
…escript_port1 ; Conflicts: ; package-lock.json ; package.json ; src/public/app/components/app_context.ts ; src/public/app/services/hoisted_note.ts ; src/public/app/services/open.ts ; src/public/app/services/toast.ts
eliandoran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.