Skip to content

Commit

Permalink
client: Focus promoted cell when clicking label
Browse files Browse the repository at this point in the history
  • Loading branch information
eliandoran committed Oct 31, 2024
1 parent ac61d0f commit db0911c
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/public/app/widgets/ribbon_widgets/promoted_attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ const TPL = `
margin: 10px;
display: table-row;
}
.promoted-attribute-cell > label {
user-select: none;
font-weight: bold;
}
.promoted-attribute-cell > * {
display: table-cell;
padding: 1px 0;
Expand Down Expand Up @@ -140,9 +144,11 @@ export default class PromotedAttributesWidget extends NoteContextAwareWidget {

async createPromotedAttributeCell(definitionAttr, valueAttr, valueName) {
const definition = definitionAttr.getDefinition();
const id = `value-${this.noteId}-${definitionAttr.position}`;

const $input = $("<input>")
.prop("tabindex", 200 + definitionAttr.position)
.prop("id", id)
.attr("data-attribute-id", valueAttr.noteId === this.noteId ? valueAttr.attributeId : '') // if not owned, we'll force creation of a new attribute instead of updating the inherited one
.attr("data-attribute-type", valueAttr.type)
.attr("data-attribute-name", valueAttr.name)
Expand All @@ -157,7 +163,7 @@ export default class PromotedAttributesWidget extends NoteContextAwareWidget {
.attr("nowrap", true);

const $wrapper = $('<div class="promoted-attribute-cell">')
.append($("<strong>").text(definition.promotedAlias ?? valueName))
.append($("<label>").prop("for", id).text(definition.promotedAlias ?? valueName))
.append($("<div>").addClass("input-group").append($input))
.append($actionCell)
.append($multiplicityCell);
Expand Down

0 comments on commit db0911c

Please sign in to comment.