Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous iteration of the turbo frame setup, and the attempted fixes in #494, #495 and #497 had some drawbacks still. One of the main ones being that the scopes were outside of the index turbo frame, so scope counts were not being updated when rows were added, deleted or filtered via a search.
This PR:
.app-main
from the#main
turbo-frame (it does not feel right for a turbo frame to be a structural element)#main
turbo-frame insideapp/views/trestle/application/_layout.html.erb
so that it can be bypassed if required.#content
turbo-frame withinapp/views/trestle/application/_layout.html.erb
that wraps utilities, tabs and content (but not the flash).#index_turbo_frame
helper and removes its usage from the templates. Existing usage should continue to work, essentially functioning as a no-op.