micronaut framework implemented. #673
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoykan
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks for the PR!
This PR does not build and compile. Could you please apply the changes, and the open the project from settings.gradle.kts level. I observe gradle-wrapper additions which should not be case for any change.
Also instead of micronaut-starter, lets keep micronaut as the name for the folder.
examples/micronaut-example/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
starters/micronaut-starter/stove-micronaut-testing-e2e/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
starters/micronaut-starter/stove-micronaut-testing-e2e/.idea/.gitignore
Outdated
Show resolved
Hide resolved
osoykan
reviewed
Dec 9, 2024
osoykan
reviewed
Dec 9, 2024
osoykan
reviewed
Dec 9, 2024
osoykan
reviewed
Dec 9, 2024
osoykan
reviewed
Dec 9, 2024
starters/micronaut-starter/stove-micronaut-testing-e2e/build.gradle.kts
Outdated
Show resolved
Hide resolved
osoykan
reviewed
Dec 9, 2024
starters/micronaut-starter/stove-micronaut-testing-e2e/build.gradle.kts
Outdated
Show resolved
Hide resolved
osoykan
reviewed
Dec 9, 2024
...-testing-e2e/src/main/kotlin/com/trendyol/stove/testing/BaseApplicationContextInitializer.kt
Outdated
Show resolved
Hide resolved
osoykan
reviewed
Dec 9, 2024
...stove-micronaut-testing-e2e/src/test/kotlin/com/trendyol/stove/testing/BridgeSystemKtTest.kt
Outdated
Show resolved
Hide resolved
osoykan
requested changes
Jan 6, 2025
starters/micronaut/stove-micronaut-testing-e2e/build.gradle.kts
Outdated
Show resolved
Hide resolved
osoykan
requested changes
Jan 6, 2025
examples/micronaut-example/src/test/kotlin/com/stove/micronaut/example/e2e/TestSystemConfig.kt
Outdated
Show resolved
Hide resolved
...s/micronaut-example/src/test/kotlin/com/stove/micronaut/example/e2e/ProductControllerTest.kt
Outdated
Show resolved
Hide resolved
...s/micronaut-example/src/test/kotlin/com/stove/micronaut/example/e2e/ProductControllerTest.kt
Outdated
Show resolved
Hide resolved
...t-example/src/main/kotlin/stove/micronaut/example/infrastructure/http/SupplierHttpService.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Anılcan <[email protected]>
Signed-off-by: Anılcan <[email protected]>
Signed-off-by: Anılcan <[email protected]>
osoykan
requested changes
Jan 9, 2025
| detektPlugins(libs.detekt.formatting) | ||
| } | ||
|
|
||
| spotless { | ||
| kotlin { | ||
| ktlint(libs.versions.ktlint.get()).setEditorConfigPath(rootProject.layout.projectDirectory.file(".editorconfig")) |
| @@ -76,13 +76,12 @@ subprojects.of("lib", "spring", "examples", "ktor") { | |||
| testImplementation(libs.kotest.runner.junit5) | |||
| testImplementation(libs.kotest.framework.api) | |||
| testImplementation(libs.kotest.property) | |||
| testImplementation(libs.kotest.arrow) | |||
| @@ -141,10 +140,11 @@ val publishedProjects = listOf( | |||
| "stove-testing-e2e-redis", | |||
| "stove-ktor-testing-e2e", | |||
| "stove-spring-testing-e2e", | |||
| "stove-spring-testing-e2e-kafka" | |||
| "stove-spring-testing-e2e-kafka", | |||
| "stove-micronaut-testing-e2e" | |||
There was a problem hiding this comment.
you can remove it for now, until it gets matured, we don't want to publish it.
| import org.slf4j.* | ||
|
|
||
| class Stove : AbstractProjectConfig() { | ||
| private val logger: Logger = LoggerFactory.getLogger("WireMockMonitor") |
There was a problem hiding this comment.
WireMockMonitor can't be, it is MicronautExample
| @@ -67,6 +72,23 @@ kotlinx-io-reactor-extensions = { module = "io.projectreactor.kotlin:reactor-kot | |||
| kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json-jvm", version.ref = "kotlinx-serialization" } | |||
| kotlinx-serialization-protobuf = { module = "org.jetbrains.kotlinx:kotlinx-serialization-protobuf", version.ref = "kotlinx-serialization" } | |||
|
|
|||
| # Micronaut | |||
| snakeyaml = { module = "org.yaml:snakeyaml", version.ref = "snakeyaml" } | |||
| micronaut-parent = { module = "io.micronaut.platform:micronaut-parent", version = "4.7.1" } | |||
There was a problem hiding this comment.
version misalignments, above 4.4.3, but here 4.7.1, all micronaut packages share the same version.
| import io.micronaut.runtime.Micronaut | ||
|
|
||
| @StoveDsl | ||
| abstract class BaseApplicationContextInitializer : ApplicationEventListener<StartupEvent> { |
There was a problem hiding this comment.
Yo don't need this one I believe.
There was a problem hiding this comment.
This is a spring-boot initializer approach, and for micronaut it is not applicable.
| } | ||
|
|
||
| companion object { | ||
| @JvmStatic fun main(args: Array<String>) { |
| override suspend fun afterProject() = TestSystem.stop() | ||
| } | ||
|
|
||
| class BridgeSystemTests : FunSpec({ |
There was a problem hiding this comment.
These tests fail. Could you take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
micronaut example created
micronaut starter created