Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose elasticsearch action results as metric #80

Conversation

uatmaca
Copy link
Contributor

@uatmaca uatmaca commented Oct 28, 2024

Pull Request Description

This PR includes changes related to Issue #60. The following modifications have been made:

Changes

  • New Metric Addition: A new metric has been added to monitor Elasticsearch actions

Tests

  • It has been confirmed that the newly added metric works correctly and returns the expected values.
go-dcp-elasticsearch-action-counter-test-image

Conclusion

These changes are expected to improve the project's provide a better user experience. Thank you for your review and feedback!

@uatmaca uatmaca force-pushed the feature/expose-elasticsearch-action-results-as-metric branch from 2bc6ff4 to 1cd9d61 Compare October 28, 2024 12:26
@3n0ugh
Copy link
Member

3n0ugh commented Oct 28, 2024

what do you think about adding index_name as a label to the Elasticsearch index success/error count metric? including the index name could make error identification more precise, particularly for mapping errors or other index-specific issues. this might also improve monitoring by allowing us to track issues per index. (when have multiple collection mapping)

@uatmaca uatmaca requested a review from 3n0ugh October 28, 2024 14:24
@uatmaca uatmaca force-pushed the feature/expose-elasticsearch-action-results-as-metric branch from 1cd9d61 to f8c6527 Compare October 29, 2024 09:24
@uatmaca uatmaca force-pushed the feature/expose-elasticsearch-action-results-as-metric branch from f8c6527 to 5d812d5 Compare October 29, 2024 10:19
@uatmaca
Copy link
Contributor Author

uatmaca commented Oct 29, 2024

what do you think about adding index_name as a label to the Elasticsearch index success/error count metric? including the index name could make error identification more precise, particularly for mapping errors or other index-specific issues. this might also improve monitoring by allowing us to track issues per index. (when have multiple collection mapping)

Done 👌
Thanks for advice 🙏 @3n0ugh

@uatmaca uatmaca self-assigned this Oct 29, 2024
@erayarslan erayarslan merged commit 2346cd6 into Trendyol:master Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants