-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(link): add link component #972
Open
erbilnas
wants to merge
32
commits into
next
Choose a base branch
from
feat/906-link-component
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,046
−24
Open
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
3280dfb
docs: implement trendyol tool hedwig to collect feedback (#957) (#959)
ogunb e3838d3
doc: add adr documents for dropdown
0e70708
fix: fix lint issue on web-test-runner and enchance structure for vs …
09a06e4
feature(dropdown): add icon support
5586612
test: upgrade version of web-test-runner and use playwright package
39aeb1a
ci: change playwright install command
970bbe6
Merge branch 'next' into feature/905-dropdown-icon-integration
erbilnas 7990fa3
ci: change playwright install command
bee34c6
Merge branch 'feature/905-dropdown-icon-integration' of https://githu…
0f6718b
ci: change playwright install command
1999d76
ci: change playwright install command
b9f3a5e
ci: change verify stages
587c056
ci: change verify stages
2dfcf53
ci: change verify stages
69a94c0
fix: fix tests
e02a819
feat(select): add feature fallback for select search
64b76b1
docs(dropdown): add icon examples to storybook
d79e960
fix(select): increase code coverage
f834d20
fix(select): increase code coverage
bcee2d9
feat(dropdown): trigger release
69738d0
feat(link): link component
df4d231
Merge branch 'next' into feat/906-link-component
erbilnas 8eff185
chore: resolve conflict
e212d11
chore: resolve conflict
ab9fe45
fix(link): set default font
c94e9a1
fix(link): change default font family
412f661
docs(link): enhance examples
a6a08cc
fix(link): remove unnecessary navigation handling
e5dc48e
feat(link): add all anchor attrs, non-standalone links support slotte…
e883edb
Merge branch 'next' into feat/906-link-component
erbilnas d6f1674
fix(link): make anchor attrs optional
2e42f4d
Merge branch 'feat/906-link-component' of https://github.com/Trendyol…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ module.exports = { | |
"table", | ||
"split-button", | ||
"datepicker", | ||
"link", | ||
], | ||
], | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +1,41 @@ | ||
export { default as BlAccordionGroup } from "./components/accordion-group/bl-accordion-group"; | ||
export { default as BlAccordion } from "./components/accordion-group/accordion/bl-accordion"; | ||
export { default as BlAccordionGroup } from "./components/accordion-group/bl-accordion-group"; | ||
export { default as BlAlert } from "./components/alert/bl-alert"; | ||
export { default as BlBadge } from "./components/badge/bl-badge"; | ||
export { default as BlButton } from "./components/button/bl-button"; | ||
export { default as BlCalendar } from "./components/calendar/bl-calendar"; | ||
export { default as BlCheckboxGroup } from "./components/checkbox-group/bl-checkbox-group"; | ||
export { default as BlCheckbox } from "./components/checkbox-group/checkbox/bl-checkbox"; | ||
export { default as BlDatepicker } from "./components/datepicker/bl-datepicker"; | ||
export { default as BlDialog } from "./components/dialog/bl-dialog"; | ||
export { default as BlDrawer } from "./components/drawer/bl-drawer"; | ||
export { default as BlDropdown } from "./components/dropdown/bl-dropdown"; | ||
export { default as BlDropdownGroup } from "./components/dropdown/group/bl-dropdown-group"; | ||
export { default as BlDropdownItem } from "./components/dropdown/item/bl-dropdown-item"; | ||
export { default as BlIcon } from "./components/icon/bl-icon"; | ||
export { default as BlInput } from "./components/input/bl-input"; | ||
export { default as BlLink } from "./components/link/bl-link"; | ||
export { default as BlNotification } from "./components/notification/bl-notification"; | ||
export { default as BlNotificationCard } from "./components/notification/card/bl-notification-card"; | ||
export { default as BlPagination } from "./components/pagination/bl-pagination"; | ||
export { default as BlPopover } from "./components/popover/bl-popover"; | ||
export { default as BlProgressIndicator } from "./components/progress-indicator/bl-progress-indicator"; | ||
export { default as BlRadioGroup } from "./components/radio-group/bl-radio-group"; | ||
export { default as BlRadio } from "./components/radio-group/radio/bl-radio"; | ||
export { default as BlSelect } from "./components/select/bl-select"; | ||
export { default as BlSelectOption } from "./components/select/option/bl-select-option"; | ||
export { default as BlTab } from "./components/tab-group/tab/bl-tab"; | ||
export { default as BlSpinner } from "./components/spinner/bl-spinner"; | ||
export { default as BlSplitButton } from "./components/split-button/bl-split-button"; | ||
export { default as BlSwitch } from "./components/switch/bl-switch"; | ||
export { default as BlTabGroup } from "./components/tab-group/bl-tab-group"; | ||
export { default as BlTabPanel } from "./components/tab-group/tab-panel/bl-tab-panel"; | ||
export { default as BlTextarea } from "./components/textarea/bl-textarea"; | ||
export { default as BlTooltip } from "./components/tooltip/bl-tooltip"; | ||
export { default as BlPopover } from "./components/popover/bl-popover"; | ||
export { default as BlDropdown } from "./components/dropdown/bl-dropdown"; | ||
export { default as BlDropdownItem } from "./components/dropdown/item/bl-dropdown-item"; | ||
export { default as BlDropdownGroup } from "./components/dropdown/group/bl-dropdown-group"; | ||
export { default as BlSwitch } from "./components/switch/bl-switch"; | ||
export { default as BlSpinner } from "./components/spinner/bl-spinner"; | ||
export { default as BlNotification } from "./components/notification/bl-notification"; | ||
export { default as BlNotificationCard } from "./components/notification/card/bl-notification-card"; | ||
export { default as BlTab } from "./components/tab-group/tab/bl-tab"; | ||
export { default as BlTable } from "./components/table/bl-table"; | ||
export { default as BlTableHeader } from "./components/table/table-header/bl-table-header"; | ||
export { default as BlTableBody } from "./components/table/table-body/bl-table-body"; | ||
export { default as BlTableRow } from "./components/table/table-row/bl-table-row"; | ||
export { default as BlTableHeaderCell } from "./components/table/table-header-cell/bl-table-header-cell"; | ||
export { default as BlTableCell } from "./components/table/table-cell/bl-table-cell"; | ||
export { default as BlSplitButton } from "./components/split-button/bl-split-button"; | ||
export { default as BlCalendar } from "./components/calendar/bl-calendar"; | ||
export { default as BlDatePicker } from "./components/datepicker/bl-datepicker"; | ||
export { default as BlTableHeaderCell } from "./components/table/table-header-cell/bl-table-header-cell"; | ||
export { default as BlTableHeader } from "./components/table/table-header/bl-table-header"; | ||
export { default as BlTableRow } from "./components/table/table-row/bl-table-row"; | ||
export { default as BlTextarea } from "./components/textarea/bl-textarea"; | ||
export { default as BlTooltip } from "./components/tooltip/bl-tooltip"; | ||
export { getIconPath, setIconPath } from "./utilities/asset-paths"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,6 +127,7 @@ | |
|
||
.grid-item { | ||
width: 93.33px; | ||
|
||
--bl-size-3xs: 15px; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
:host { | ||
display: inline-flex; | ||
align-items: center; | ||
} | ||
|
||
.link { | ||
/* Custom properties */ | ||
--color: var(--bl-link-color, var(--bl-color-primary)); | ||
--hover-color: var(--bl-link-hover-color, var(--bl-color-primary-highlight)); | ||
--active-color: var(--bl-link-active-color, var(--bl-color-primary-highlight)); | ||
|
||
/* Base styles */ | ||
display: inline-flex; | ||
align-items: center; | ||
color: var(--color); | ||
cursor: pointer; | ||
outline: none; | ||
position: relative; | ||
} | ||
|
||
/* States */ | ||
.link:hover { | ||
text-decoration: none; | ||
} | ||
|
||
.link:hover:not(.disabled) { | ||
color: var(--hover-color); | ||
} | ||
|
||
.link:active:not(.disabled) { | ||
color: var(--active-color); | ||
} | ||
|
||
/* Focus styles */ | ||
.link:focus-visible { | ||
outline: none; | ||
} | ||
|
||
.link:focus-visible::after { | ||
content: ""; | ||
position: absolute; | ||
inset: -2px; | ||
border: 2px solid var(--bl-color-primary); | ||
border-radius: var(--bl-border-radius-s); | ||
} | ||
|
||
/* Primary kind */ | ||
.link.standalone.kind-primary { | ||
color: var(--bl-color-primary); | ||
} | ||
|
||
.link.standalone.kind-primary:hover:not(.disabled), | ||
.link.standalone.kind-primary:active:not(.disabled) { | ||
color: var(--bl-color-primary-highlight); | ||
} | ||
|
||
/* Neutral kind */ | ||
.link.standalone.kind-neutral { | ||
color: var(--bl-color-neutral); | ||
} | ||
|
||
.link.standalone.kind-neutral:hover:not(.disabled), | ||
.link.standalone.kind-neutral:active:not(.disabled) { | ||
color: var(--bl-color-neutral-highlight); | ||
} | ||
|
||
/* Size variants */ | ||
.link.standalone.size-large { | ||
font-weight: var(--bl-font-weight-regular); | ||
font-size: var(--bl-font-size-l); | ||
} | ||
|
||
.link.standalone.size-medium { | ||
font-weight: var(--bl-font-weight-regular); | ||
font-size: var(--bl-font-size-m); | ||
} | ||
|
||
.link.standalone.size-small { | ||
font-weight: var(--bl-font-weight-regular); | ||
font-size: var(--bl-font-size-s); | ||
} | ||
|
||
/* Icon styles */ | ||
.icon { | ||
margin-inline-start: var(--bl-size-3xs); | ||
} | ||
|
||
/* Disabled state */ | ||
.link.disabled { | ||
opacity: 0.5; | ||
cursor: not-allowed; | ||
} | ||
|
||
/* Screen reader only text */ | ||
.visually-hidden { | ||
position: absolute; | ||
block-size: 1px; | ||
inline-size: 1px; | ||
padding: 0; | ||
margin: -1px; | ||
overflow: hidden; | ||
clip: rect(0, 0, 0, 0); | ||
white-space: nowrap; | ||
border: 0; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we change casing? that could be a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's breaking tests and btw it already named like that
export default class BlDatepicker extends DatepickerCalendarMixin {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should talk with @dilandoogan